Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto setup #66

Merged
merged 9 commits into from
May 29, 2024
Merged

Auto setup #66

merged 9 commits into from
May 29, 2024

Conversation

abdelaziz-mahdy
Copy link
Contributor

@abdelaziz-mahdy abdelaziz-mahdy commented May 28, 2024

Platforms and Testing Checklist

fixing #65

no need to remove the setup script, i just used it to setup the platform binaries when building

  • Android
    • Implemented
    • Tested
  • MacOS
    • Implemented
    • Tested
  • iOS
    • Implemented
    • Tested
  • Linux
    • Implemented
    • Tested
  • Windows
    • Implemented
    • Tested

@abdelaziz-mahdy abdelaziz-mahdy marked this pull request as ready for review May 28, 2024 21:06
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (4af53ea) to head (6403bb0).

Current head 6403bb0 differs from pull request most recent head 67c3744

Please upload reports for the commit 67c3744 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files          36       36           
  Lines        4897     4897           
=======================================
  Hits         4357     4357           
  Misses        540      540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainyl
Copy link
Owner

rainyl commented May 29, 2024

working for every platform now, maybe ready to merge, could you please test whether it works for ios? @abdelaziz-mahdy

@abdelaziz-mahdy
Copy link
Contributor Author

image

trying on simulator fails, but the files was added, so i think its working correctly

Launching lib/main.dart on iPhone 15 Pro in debug mode...
Xcode build done.                                           12.7s
Failed to build iOS app
Error (Xcode): Building for 'iOS-simulator', but linking in dylib (/Users/AbdelazizMahdy/flutter_projects/opencv_dart/ios/opencv_dart.framework/opencv_dart) built for 'iOS'

Error (Xcode): Linker command failed with exit code 1 (use -v to see invocation)

Could not build the application for the simulator.
Error launching application on iPhone 15 Pro.

@rainyl rainyl self-requested a review May 29, 2024 12:15
Copy link
Owner

@rainyl rainyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@rainyl rainyl merged commit a04f909 into rainyl:main May 29, 2024
5 checks passed
@rainyl rainyl linked an issue May 29, 2024 that may be closed by this pull request
@rainyl rainyl mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove setup script, download libs when building
3 participants