-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meson] Add unit tests in Fortran #66
Conversation
Sorry, I forget to push all of the u_*_threaded.f files. Now done. The cdhj issue was a bug on my part, I forgot to add the ", thread" argument. Fixed. We have talked about 64-bit cutest before, and as I said this is highly non trivial as we would have to make a breaking change to sifdecode #53 . We agreed not to implement this at the time. As I said, there is no need for 64 bits in CUTEst at the moment as no SIF example gets close to that limit. And I did suggest that if we do need this, someone else from the team should do it. The q_*.f functions are just to test QPs ctest2.F90 is just to debug an individual tool (for my convenience). Just use ctest.F90, and ignore ctest2.F90 |
Actually, I suppose there is no reason not to test 64 bit cutest with invented c_elfun_s_64 (etc) that we construct. The sifdecoder can't do this (at the moment) All that would be needed would be to duplicate all of the c_.f q_.f and u_.f to have names c_64.f q64.f and u_64.f, and for each of these new duplicates insert a line We would also have to modify ./include/cutest_modules_single.h (etc) to add a _64 if 64 bit integers are used as we did for GALAHAD, when buidling the 64 bit cutest libraries |
4ff9919
to
4f90f2f
Compare
Thanks you Nick for the fixes and explanation.
When I added the tests, I assumed that files like I propose that we wait until there is a demand or work on a 64-bit decoder before focusing on tests in GALAHAD. I prefer to add tests for what is currently supposed to work (like the C interface in issue #64 and potential issues in the All tests passed, so I'll merge the pull request. |
Nick, it seems that a file
u_elfun_quadruple.f
is missing insrc/test
.I have some comments on the Fortran tests:
Meson doesn't return en error because it just prints things and it's not a segmentation fault.
q_group_*.f
,q_elfun_*.f
,q_range_*.f
?ctest.F90
and / orctest2.F90
?