-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay metadata component load until after config is received #553
base: main
Are you sure you want to change the base?
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-521 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @IshavSohal)
server/index.js
line 601 at r1 (raw file):
const payload = JSON.stringify(message); clients.forEach((client) => { if (client.readyState === WebSocketServer.OPEN) {
Please remove the changes to index.js. The spacing to the types are fine but WebSocketServer.OPEN
should be set to WebSocket.OPEN
or 1
locally. Otherwise this works well.
9553fc4
to
c7b65d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @szczz)
server/index.js
line 601 at r1 (raw file):
Previously, szczz (Matt Szczerba) wrote…
Please remove the changes to index.js. The spacing to the types are fine but
WebSocketServer.OPEN
should be set toWebSocket.OPEN
or1
locally. Otherwise this works well.
Donethanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
Related Item(s)
#521
Changes
loadStatus
to 'loaded') until the product's config is received from the serverbroadcastToClients()
in the serverTesting
Steps:
This change is