Stop installing the js2wasm plugin

The latest Spin JS SDK no longer uses it, and the upstream spin installer no longer installs it by default: fermyon/developer#1357 Signed-off-by: Jan Dubois <[email protected]> (cherry picked from commit dcf46c5)
rancher-sandbox · Jan 17, 2025 · 5db923b · 5db923b
1 parent 4ff5beb
commit 5db923b
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 13 deletions.
diff --git a/bats/tests/utils/spin.bats b/bats/tests/utils/spin.bats
@@ -41,8 +41,6 @@ dir_exists() {
 }
 
 @test 'plugins are installed' {
-    run dir_exists "${SPIN_DATA_DIR}/plugins/js2wasm"
-    assert_success
     run dir_exists "${SPIN_DATA_DIR}/plugins/kube"
     assert_success
 }

diff --git a/pkg/rancher-desktop/assets/dependencies.yaml b/pkg/rancher-desktop/assets/dependencies.yaml
@@ -25,4 +25,3 @@ spinOperator: 0.4.0
 certManager: 1.16.3
 spinCLI: 3.1.2
 spinKubePlugin: 0.3.1
-js2wasmPlugin: 0.6.1
diff --git a/pkg/rancher-desktop/backend/lima.ts b/pkg/rancher-desktop/backend/lima.ts
@@ -1512,9 +1512,8 @@ export default class LimaBackend extends events.EventEmitter implements VMBacken
         const version = semver.parse(DEPENDENCY_VERSIONS.spinCLI);
         const env = {
           ...process.env,
-          KUBE_PLUGIN_VERSION:    DEPENDENCY_VERSIONS.spinKubePlugin,
-          JS2WASM_PLUGIN_VERSION: DEPENDENCY_VERSIONS.js2wasmPlugin,
-          SPIN_TEMPLATE_BRANCH:   (version ? `v${ version.major }.${ version.minor }` : 'main'),
+          KUBE_PLUGIN_VERSION:  DEPENDENCY_VERSIONS.spinKubePlugin,
+          SPIN_TEMPLATE_BRANCH: (version ? `v${ version.major }.${ version.minor }` : 'main'),
         };
 
         promises.push(this.spawnWithCapture(executable('setup-spin'), { env }));

diff --git a/pkg/rancher-desktop/backend/wsl.ts b/pkg/rancher-desktop/backend/wsl.ts
@@ -1345,9 +1345,8 @@ export default class WSLBackend extends events.EventEmitter implements VMBackend
                 try {
                   const version = semver.parse(DEPENDENCY_VERSIONS.spinCLI);
                   const env = {
-                    KUBE_PLUGIN_VERSION:    DEPENDENCY_VERSIONS.spinKubePlugin,
-                    JS2WASM_PLUGIN_VERSION: DEPENDENCY_VERSIONS.js2wasmPlugin,
-                    SPIN_TEMPLATE_BRANCH:   (version ? `v${ version.major }.${ version.minor }` : 'main'),
+                    KUBE_PLUGIN_VERSION:  DEPENDENCY_VERSIONS.spinKubePlugin,
+                    SPIN_TEMPLATE_BRANCH: (version ? `v${ version.major }.${ version.minor }` : 'main'),
                   };
                   const wslenv = Object.keys(env).join(':');
 

diff --git a/pkg/rancher-desktop/integrations/windowsIntegrationManager.ts b/pkg/rancher-desktop/integrations/windowsIntegrationManager.ts
@@ -524,9 +524,8 @@ export default class WindowsIntegrationManager implements IntegrationManager {
     if (state && this.settings.experimental?.containerEngine?.webAssembly) {
       const version = semver.parse(DEPENDENCY_VERSIONS.spinCLI);
       const env = {
-        KUBE_PLUGIN_VERSION:    DEPENDENCY_VERSIONS.spinKubePlugin,
-        JS2WASM_PLUGIN_VERSION: DEPENDENCY_VERSIONS.js2wasmPlugin,
-        SPIN_TEMPLATE_BRANCH:   (version ? `v${ version.major }.${ version.minor }` : 'main'),
+        KUBE_PLUGIN_VERSION:  DEPENDENCY_VERSIONS.spinKubePlugin,
+        SPIN_TEMPLATE_BRANCH: (version ? `v${ version.major }.${ version.minor }` : 'main'),
       };
       const wslenv = Object.keys(env).join(':');
 

diff --git a/resources/setup-spin b/resources/setup-spin
@@ -53,7 +53,6 @@ install_templates spin "${SPIN_TEMPLATE_BRANCH:-main}"
 install_templates spin-python-sdk main
 install_templates spin-js-sdk main
 
-install_plugin js2wasm "${JS2WASM_PLUGIN_VERSION:-0.6.1}"
 install_plugin kube "${KUBE_PLUGIN_VERSION:-0.3.1}"
 
 echo "'${spin}' setup complete"