Update: address review comments

#882 (comment) #882 (comment) Signed-off-by: Mark Yen <[email protected]>
rancher-sandbox · Oct 29, 2021 · c0a56a9 · c0a56a9
1 parent 30b3a37
commit c0a56a9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/update/LonghornProvider.ts b/src/main/update/LonghornProvider.ts
@@ -138,11 +138,11 @@ export async function hasQueuedUpdate(): Promise<boolean> {
     const stagedVersion = semver.parse(cache.release.tag, { loose: true });
 
     if (!currentVersion || !stagedVersion) {
-      console.log(`Error parsing staged versions: ${ currentVersion } -> ${ stagedVersion }`);
+      console.log(`Error parsing staged versions: ${ currentVersion ?? '<none>' } -> ${ stagedVersion ?? '<none>' }`);
 
       return false;
     }
-    if (currentVersion.compare(stagedVersion) >= 0) {
+    if (semver.gte(currentVersion, stagedVersion)) {
       console.log(`Staged version ${ stagedVersion } not greater than current version ${ currentVersion }, skipping.`);
 
       return false;