Fix cloud provider installation in AWS template #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
previously approved these changes
Feb 25, 2025
furkatgofurov7
previously approved these changes
Feb 25, 2025
| @@ -229,6 +235,7 @@ apiVersion: addons.cluster.x-k8s.io/v1beta1 | |||
| kind: ClusterResourceSet | |||
| metadata: | |||
| name: crs-ccm | |||
| namespace: ${NAMESPACE} | |||
There was a problem hiding this comment.
I think when specifying -n <namespace> in kubectl apply, namespace is being set for each resource from the list. It may however conflict with an already set value. Could this value be removed from templates instead?
There was a problem hiding this comment.
@Danil-Grigorev the namespace is there to align with clusterctl templates, where it's used to substitute namespace in generate command
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
force-pushed
the
awstemplate
branch
from
c9f7cd0 to
74764d8
Compare
kkaempf
added
area/documentation
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
dismissed stale reviews from furkatgofurov7 and anmazzotti
via
cae8f95
furkatgofurov7
approved these changes
Feb 26, 2025
anmazzotti
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: