Add Event schema null checks #13478
Merged
Add Event schema null checks #13478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchiaf
commented
Feb 21, 2025
| @@ -75,23 +75,25 @@ export default { | |||
| const inStore = this.$store.getters['currentStore'](EVENT); | |||
| const eventSchema = this.$store.getters[`${ inStore }/schemaFor`](EVENT); // @TODO be smarter about which resources actually ever have events | |||
|
|
|||
| const paginationHeaders = eventSchema ? [ | |||
There was a problem hiding this comment.
paginationHeaders can be an empty array since the UI shows events only if event schema is not null:
showEvents() {
return this.isView && this.needEvents && this.eventSchema;
},
torchiaf
force-pushed
the
13477-event-schema
branch
3 times, most recently
from
a1af300 to
0ccfec7
Compare
richard-cox
requested changes
Feb 24, 2025
| @@ -35,7 +35,7 @@ export default { | |||
|
|
|||
| const schema = this.$store.getters['cluster/schemaFor'](EVENT); | |||
|
|
|||
| const paginationHeaders = [ | |||
| const paginationHeaders = schema ? [ | |||
There was a problem hiding this comment.
Are changes to this file needed? the events table isn't shown if the type can't been seen
There was a problem hiding this comment.
In theory no, this is just a null check for the component itself. It doesn't hurt, I would keep it, so that if the EventTable is shown by any mistake, the UI doesn't crash.
Signed-off-by: Francesco Torchia <[email protected]>
Co-authored-by: Richard Cox <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
torchiaf
force-pushed
the
13477-event-schema
branch
from
ed764b1 to
68e9820
Compare
richard-cox
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13477
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist