Use correct architecture for yum repo instead of hardcoding x86_64 #6927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
requested changes
Oct 3, 2024
|
@vitorsavian is this still an issue after your recent PRs? |
uname -m is the proper way to do this, rather than ARCH Co-authored-by: Brad Davidson <[email protected]>
brandond
approved these changes
Oct 3, 2024
|
I suspect we didn't actually test installing RPMs using the install script on arm64. We only checked to see that they are built and published. |
|
Tested the patch with Also we updated our tests to |
brandond
changed the title
briandowns
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I'm working on fixing the RPM install process for ARM64
aarch64architecture type.Does not require a change to docs
Types of Changes
Minor bug fixes to enable RPM installs of
aarch64Verification
Run the following command on an ARM64 version of Rocky 8:
Testing
Not covered by testing
Linked Issues
#6926
User-Facing Change
Further Comments
Quick fix, not a major change