DigitalOcean Example Improvements #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/rke instead of hashicorp/rke; also, modified examples/digitalocean/do/versions.tf so we try and pull digitalocean/digitalocean instead of hashicorp/digitalocean
…ates.tf to cleanup interpolation-only expression warnings
for Terraform v0.13+
…re-gates, since this is no longer required by csi-digitalocean v2.1.1
…et feature-gates, since this is no longer required by csi-digitalocean v2.1.1" This reverts commit f2c040b.
…re-gates, since this is no longer required by csi-digitalocean v2.1.1
…gates, since declaring this hasn't been allowed since K8s v1.16
kube_config_cluster.yml produced by a successful build
kube_api service
do/variables.tf to use RancherOS image instead of Ubuntu 18.04 LTS
to update kubelet paths for compatability with RKE. RKE uses /opt/rke/var/lib/kubelet instead of /var/lib/kubelet
deployed by Terraform. Also added section describing how to destroy the cluster, once created.
the temporary ./terraform-provider-rke-tmp* directory that gets created during cluster provisioning
directories and rke.tf to: 1. make it easier to discern where to define variables, 2. improve commenting, 3. enable specifying different droplet sizes for controlplane and worker nodes, 4. add support for the cluster_domain kubelet argument, 5. make droplet names more meaningful, 6. apply droplet names to nodes in RKE cluster, 7. define RKE node blocks dynamically to make it easier to add and remove nodes from the cluster by incrementing/decrementing the (new) node_count variables
|
Issue #270 |
rawmind0
suggested changes
Feb 10, 2021
There was a problem hiding this comment.
@jadamcraig , thanks for the PR
It LGTM, but before merge, could you please squash the commits??
|
@rawmind0 -- Absolutely! |
|
@jadamcraig any update here about the changes requested?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently had the opportunity (call it too much free time over the holidays) to overhaul the DigitalOcean example (
./examples/digitalocean/), and thought some or all of these tweaks might be of interest to the community and the project.Specifically, the changes include:
rke.tfto support the latestrancher/rke.digitalocean-cloud-controller-managerupgraded from v0.1.15 to v0.1.30.csi-digitaloceanupgraded from v1.0.1 to v2.1.1.driver.yamlto support RKE. Specifically,csi-digitalocean, as provided, expectskubeletto use/var/lib/kubelet, whereas RKE uses/opt/rke/var/lib/kubeletvar/lib/kubelet. The specific changes from the DO-provided copy are noted inexamples/digitalocean/files/csi-digitalocean-v2.1.1/driver.yaml.controlplaneandworkernodes, respectively.rke.tfto simplify adding/removing nodes from the cluster, before or after initial provisioning.cluster_domainkubeletargument, which is also passed to DigitalOcean when droplets are provisioned so that droplet names match the names of the RKE nodes in the cluster whenkubectl get nodesis run.README.md.