Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Represent region-specific pricing when configuring LKE Node Pools #5065

Merged

Conversation

lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Sep 7, 2023

Proposed changes

This change adjusts the LKE cluster creation UI to represent upcoming LKE Node Pool pricing changes.

Types of changes

  • Adjusts the displayed hourly and monthly pricing for each LKE Node Pool plan to reflect region-specific pricing exceptions.
  • Adds a notice displayed when a user's Node Pool configuration is affected by any region-specific pricing exceptions.

Linked Issues

Related issue rancher/rancher#42702

Preview

Configuring node pools in a region with pricing exceptions (id-cgk):

Configuring node pools in a region with pricing exceptions

@lgarber-akamai lgarber-akamai marked this pull request as ready for review October 4, 2023 22:54
Copy link

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nwmac
Copy link
Member

nwmac commented Sep 9, 2024

Is this still needed? Sorry, its been open a long time - let me know.

@lgarber-akamai
Copy link
Contributor Author

Is this still needed? Sorry, its been open a long time - let me know.

Hey @nwmac, sorry for the late response!

This is still needed — there are a select few Linode regions with prices that aren't properly reflected on the LKE node pool configuration page.

@gaktive gaktive requested a review from nwmac October 7, 2024 16:15
@nwmac nwmac force-pushed the new/region-specific-pricing branch from e0fccc9 to b95c27d Compare December 9, 2024 17:21
@mantis-toboggan-md mantis-toboggan-md merged commit ae0f3f3 into rancher:master Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants