Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of marked and dompurify dependencies #5188

Merged
merged 4 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/apps-tab/detail/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@
expand=(action expandFn)
expandOnInit=false
}}
{{marked-down
markdown=model.app.notes
}}
{{t "generic.removed" }}
{{/accordion-list-item}}
{{/if}}

Expand Down
4 changes: 2 additions & 2 deletions app/components/new-catalog/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</div>
<div class="col span-8">
{{#if appReadmeContent}}
{{marked-down markdown=appReadmeContent}}
{{t "generic.removed" }}
{{else if (not noAppReadme)}}
<div class="text-center">
<i class="icon icon-spinner icon-spin icon-3x"></i>
Expand Down Expand Up @@ -66,7 +66,7 @@
<div class="row">
{{#if readmeContent}}
<div class="col span-12" style="overflow-y: auto; max-height: 500px;">
{{marked-down markdown=readmeContent}}
{{t "generic.removed" }}
</div>
{{else}}
<h2 class="mb-10">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</div>
<div class="col span-8">
{{#if appReadmeContent}}
{{marked-down markdown=appReadmeContent}}
{{t "generic.removed" }}
{{else if (not noAppReadme)}}
<div class="text-center">
<i class="icon icon-spinner icon-spin icon-3x"></i>
Expand Down Expand Up @@ -59,7 +59,7 @@
<div class="row">
{{#if readmeContent}}
<div class="col span-12 readme-content">
{{marked-down markdown=readmeContent}}
{{t "generic.removed" }}
</div>
{{else}}
<h2 class="mb-10">
Expand Down
42 changes: 0 additions & 42 deletions lib/shared/addon/components/marked-down/component.js

This file was deleted.

1 change: 0 additions & 1 deletion lib/shared/addon/components/marked-down/template.hbs

This file was deleted.

1 change: 0 additions & 1 deletion lib/shared/app/components/marked-down/component.js

This file was deleted.

2 changes: 0 additions & 2 deletions lib/shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"dependencies": {
"async": "*",
"d3": "*",
"dompurify": "*",
"echarts": "*",
"@rancher/ember-api-store": "*",
"ember-auto-import": "*",
Expand All @@ -27,7 +26,6 @@
"json2yaml": "*",
"jsyaml": "*",
"liquid-fire": "*",
"marked": "*",
"prettycron": "*",
"prismjs": "*",
"semver": "*",
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"babel-eslint": "^10.1.0",
"broccoli-asset-rev": "^3.0.0",
"d3": "3.5.17",
"dompurify": "^2.1.1",
"dot-object": "^2.1.4",
"dotenv": "^8.2.0",
"echarts": "4.9.0",
Expand Down Expand Up @@ -92,7 +91,6 @@
"jsondiffpatch": "^0.4.1",
"linkifyjs": "^2.1.9",
"loader.js": "^4.7.0",
"marked": "^2.0.0",
"moment": "~2.29.0",
"node-sass": "4.14.1",
"objects-to-csv": "^1.3.5",
Expand Down
1 change: 1 addition & 0 deletions translations/en-us.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ generic:
persistentVolume: persistent volume
random: Random
remove: Remove
removed: Functionality has been removed from the legacy UI
restarts: Restarts
role: Role
save: Save
Expand Down
Loading
Loading