-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.3] [GHA] Migrate v0.3 to GHA #385
[v0.3] [GHA] Migrate v0.3 to GHA #385
Conversation
c11fa0a
to
e606b15
Compare
ee78da6
to
1ac6bed
Compare
9f83c60
to
bd9026b
Compare
bd9026b
to
b841c28
Compare
- backport changes to v0.5 - use k8s 1.27 - include setting capi.port -- this stopped happening with v 0.4 - rancher 2.7 chart still insists on k8s 1.26 tops - Install rancher against an up-to-date chart.
b841c28
to
6e3cc82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions on a few other changes that were backported that are unrelated to the GHA PR, but outside of that looks good.
Dockerfile.dapper
Outdated
ENV HELM_UNITTEST_VERSION 0.3.2 | ||
|
||
RUN zypper -n install git docker vim less file curl wget awk | ||
|
||
RUN curl -sL https://get.helm.sh/helm-${HELM_VERSION}-linux-${ARCH}.tar.gz | tar xvzf - -C /usr/local/bin --strip-components=1 | ||
|
||
RUN if [ "${ARCH}" = "amd64" ]; then \ | ||
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.54.0; \ | ||
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.57.1; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this upgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My usual reason of pulling in newer non-rancher components when backporting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I backed that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. 👍
Backport PR 383 (migrate v0.5 to GHA)
Related to rancher/rancher#45231