Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.3] [GHA] Migrate v0.3 to GHA #385

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

ericpromislow
Copy link
Contributor

Backport PR 383 (migrate v0.5 to GHA)

Related to rancher/rancher#45231

@ericpromislow ericpromislow requested a review from a team as a code owner May 29, 2024 23:20
@ericpromislow ericpromislow marked this pull request as draft May 31, 2024 19:39
@ericpromislow ericpromislow force-pushed the gha-migration-v0.3 branch 2 times, most recently from c11fa0a to e606b15 Compare June 15, 2024 00:03
@ericpromislow ericpromislow marked this pull request as ready for review June 27, 2024 22:40
@ericpromislow ericpromislow requested a review from MbolotSuse June 27, 2024 22:59
@ericpromislow ericpromislow changed the title Migrate v0.3 to GHA [v0.3] [GHA] Migrate v0.3 to GHA Jul 5, 2024
- backport changes to v0.5
- use k8s 1.27
- include setting capi.port -- this stopped happening with v 0.4
- rancher 2.7 chart still insists on k8s 1.26 tops
- Install rancher against an up-to-date chart.
Copy link
Contributor

@MbolotSuse MbolotSuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions on a few other changes that were backported that are unrelated to the GHA PR, but outside of that looks good.

ENV HELM_UNITTEST_VERSION 0.3.2

RUN zypper -n install git docker vim less file curl wget awk

RUN curl -sL https://get.helm.sh/helm-${HELM_VERSION}-linux-${ARCH}.tar.gz | tar xvzf - -C /usr/local/bin --strip-components=1

RUN if [ "${ARCH}" = "amd64" ]; then \
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.54.0; \
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.57.1; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this upgraded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My usual reason of pulling in newer non-rancher components when backporting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I backed that out.

nflynt
nflynt previously approved these changes Aug 6, 2024
Copy link
Contributor

@nflynt nflynt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

@nflynt nflynt merged commit 72bee62 into rancher:release/v0.3 Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants