Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VectorGrid support #109

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Add VectorGrid support #109

merged 3 commits into from
Jan 3, 2023

Conversation

blackary
Copy link
Collaborator

@blackary blackary commented Jan 3, 2023

Fixes #107

@kotfic
Copy link

kotfic commented Jan 3, 2023

Tested locally, getting good vector tiles. Thanks!

@kotfic
Copy link

kotfic commented Jan 3, 2023

FWIW setting "interactive": True on the VectorGridProtobuf layer causes errors due to an upstream bug Leaflet/Leaflet.VectorGrid#273 Not sure there is anything to do about it.

Base automatically changed from fix-bug to master January 3, 2023 20:17
@randyzwitch
Copy link
Owner

This has a merge conflict now @blackary

@blackary
Copy link
Collaborator Author

blackary commented Jan 3, 2023

@kotfic If the bug is on the underlying Leaflet library, it will likely be difficult to fix in this package (not necessarily impossible, but much more difficult, since this is two layers above leaflet -- leaflet -> folium -> streamlit-folium). Do you have an example streamlit script which shows the issue?

@randyzwitch randyzwitch merged commit 18c7294 into master Jan 3, 2023
@randyzwitch randyzwitch deleted the vector-grid-support branch January 3, 2023 20:25
@kotfic
Copy link

kotfic commented Jan 3, 2023

@blackary yeah sorry not suggesting any action item on this PR. There are 4 or 5 issues on Leaflet.VectorGrid describing the problem, seeing as the last real commit on that library was July 2019 I don't have much hope of it being fixed. Its just a bummer that it has the function (so the duck typing passes) but the function is broken. It is equally a bummer that leaflet/javascript doesn't support determining the layer type so onLayerClick can't easily skip implement a code path that avoids the exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

folium-vectorgrid support?
3 participants