Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundler version #19184

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

adfoster-r7
Copy link
Contributor

@adfoster-r7 adfoster-r7 commented May 15, 2024

Closes #19316
Closes #19492

Update bundler version

Verification

  • Ensure CI passes
  • Test the branch on your local dev environment, i.e. for my Kali machine:
┌──(vagrant㉿Kali)-[~/metasploit-framework]
└─$ bundle                                                                                                                                                                                
Bundler 2.3.27 is running, but your lockfile was generated with 2.5.10. Installing Bundler 2.5.10 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 2.5.10
...

┌──(vagrant㉿Kali)-[~/metasploit-framework]
└─$ bundle exec ruby ./msfconsole -v                                                                                                                                                    
Framework Version: 6.4.28-dev-9ff47b0eb3

@adfoster-r7 adfoster-r7 force-pushed the update-bundler-version branch 9 times, most recently from 2223278 to 7d31f68 Compare May 16, 2024 14:12
@adfoster-r7 adfoster-r7 marked this pull request as draft May 16, 2024 17:20
@adfoster-r7 adfoster-r7 reopened this Jul 11, 2024
@adfoster-r7 adfoster-r7 force-pushed the update-bundler-version branch from 7d31f68 to 5bf3494 Compare July 11, 2024 00:19
@adfoster-r7 adfoster-r7 marked this pull request as ready for review September 24, 2024 09:27
@adfoster-r7 adfoster-r7 force-pushed the update-bundler-version branch from 5bf3494 to 9ff47b0 Compare September 24, 2024 09:29
Copy link
Contributor

@jheysel-r7 jheysel-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

➜  metasploit-framework git:(9ff47b0eb3) ✗ bundle
Bundle complete! 18 Gemfile dependencies, 216 gems now installed.
Bundled gems are installed into `./vendor/bundle`
1 installed gem you directly depend on is looking for funding.
  Run `bundle fund` for details
➜  metasploit-framework git:(9ff47b0eb3) ✗ bundle exec ruby ./msfconsole -v
Framework Version: 6.4.28-dev-9ff47b0eb3

@adfoster-r7 adfoster-r7 merged commit 480a938 into rapid7:master Sep 24, 2024
78 checks passed
@adfoster-r7 adfoster-r7 deleted the update-bundler-version branch September 24, 2024 16:02
@adfoster-r7
Copy link
Contributor Author

adfoster-r7 commented Sep 24, 2024

Release Notes

This updates bundler version and fixes multiple warnings when booting msfconsole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gem::Platform.match is deprecated DidYouMean::SPELL_CHECKERS.merge Deprecation
3 participants