Remove hardcoded secret #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeherdt-r7
reviewed
Jun 25, 2024
| # If you change this key, all old signed cookies will become invalid! | ||
| # Make sure the secret is at least 30 characters and all random, | ||
| # no regular words or you'll be exposed to dictionary attacks. | ||
| Dummy::Application.config.secret_token = 'f04f565f9a4db0f0af88f4bd8b79952d139b02434b889a7c7bb3fe83405e9032409bd16bca7b0d7d68a8b119b6ddfd31b17d19155cd699a27e19a48bd05eb200' |
There was a problem hiding this comment.
Similar to the discussion in the metasploit-concerns, I'd recommend to replace this with an ENV read-out, and update the documentation to use a .env file with a generated value.
There was a problem hiding this comment.
Cross-referencing response: rapid7/metasploit-credential#181 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a snyk issue with a hardcoded secret, not a valid security concern since it's in the test suite but it can be removed anyway, I was able to remove the whole file since
secret_tokenhasn't been in use since migrating to rails 4https://guides.rubyonrails.org/v4.0.8/upgrading_ruby_on_rails.html#:~:text=%23%20end-,2.6%20Action%20Pack,-Rails%204.0%20introduces