Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change indicators to list instead one value #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change indicators to list instead one value #6

wants to merge 2 commits into from

Conversation

r7-mgorny
Copy link
Contributor

Description

MC-231 - Change indicators to list instead one value

Testing

python3 -m unittest discover unit_test
.................................
----------------------------------------------------------------------
Ran 33 tests in 1.914s

OK

joey-mcadams
joey-mcadams suggested changes May 4, 2021
View reviewed changes
eml_parser/email_parser.py
indicators = []
for part in msg.walk():
if not part.is_multipart():
indicators.append(Indicators(self.get_body(part)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that going to return the whole body instead of just the indicator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joey-mcadams joey-mcadams joey-mcadams requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r7-mgorny @joey-mcadams