Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MC-514] Parse dkim, spf and dmarc indicators from Authentication-Results header #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MC-514] Parse dkim, spf and dmarc indicators from Authentication-Results header #7

wants to merge 3 commits into from

Conversation

dsliwinski-r7
Copy link

@dsliwinski-r7 dsliwinski-r7 commented Oct 4, 2021 •
edited
Loading

Description

MC-514 - parse dkim, spf and dmarc indicators from Authentication-Results header

Testing

python3 -m unittest discover unit_test
...................................<class 'int'>
.....
----------------------------------------------------------------------
Ran 40 tests in 0.973s

OK

@dsliwinski-r7 dsliwinski-r7 changed the title [MC-514] Parse dkim, spf and dmarc indicators from Authentication header [MC-514] Parse dkim, spf and dmarc indicators from Authentication-Results header Oct 6, 2021
pmara-r7
pmara-r7 suggested changes Jan 6, 2022
View reviewed changes
Copy link

@pmara-r7 pmara-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, looks good to me otherwise

eml_parser/indicators.py Outdated Show resolved Hide resolved
akarolik-r7
akarolik-r7 suggested changes Apr 26, 2022
View reviewed changes
eml_parser/indicators.py Outdated Show resolved Hide resolved
@dsliwinski-r7 dsliwinski-r7 requested a review from akarolik-r7 May 4, 2022 08:24
@r7-kszczepanskagorna r7-kszczepanskagorna self-requested a review May 5, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrandys-r7 mgrandys-r7 mgrandys-r7 approved these changes

@akarolik-r7 akarolik-r7 akarolik-r7 approved these changes

@pmara-r7 pmara-r7 pmara-r7 approved these changes

@r7-kszczepanskagorna r7-kszczepanskagorna r7-kszczepanskagorna approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsliwinski-r7 @r7-kszczepanskagorna @pmara-r7 @akarolik-r7 @mgrandys-r7