Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and refactor Efsrpc #259

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

zeroSteiner
Copy link
Contributor

This makes a few changes that will be required by a forthcoming PR to the Metasploit Framework's existing petitpotam module.

  • 5377044 -- This fixes a bug where frozen strings in the endpoint definitions would cause a crash. The update changes it so the uuid_string argument is not mutated.
  • 45ad5be -- This makes some changes so that RubySMB's named pipe can be used for Efsrpc requests. The Request class needed to be updated so the #dcerpc_request method would accept the requests.
  • 9a64a6d -- This adds the minimum definition to allow connecting to the LSARPC endpoint by defining the UUID and version constants.
  • 9591eb6 -- This refactors the EncryptingFileSystem module to be renamed Efsrpc which makes it more consistent with the other DCERPC module that are named after the well-known pipe a user would connect to. See the definitions in pipe.rb for an example of how most modules are named after the pipe name.

The UUID could be a frozen constant from one of the modules.
The DCERPC modules are mostly named after the well-known pipe that a
user would connect to.
@adfoster-r7 adfoster-r7 merged commit cf3d0cf into rapid7:master Dec 15, 2023
6 checks passed
@adfoster-r7
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants