[2.x] Get option labels with attribute options in the cart #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indykoning
reviewed
Feb 10, 2025
|
Updated PR |
indykoning
reviewed
Mar 5, 2025
| @@ -37,4 +37,8 @@ export const attributes = computedAsync( | |||
| { lazy: true, shallow: false }, | |||
| ) | |||
|
|
|||
| window.attributeLabel = (attributeCode) => { | |||
| return Object.values(attributes.value)?.find((attribute) => attribute.code === attributeCode)?.name | |||
There was a problem hiding this comment.
I think we might want to return a computed value of this expression.
attributes is a lazy computed async. It will only be fetched when it's used and returns a default value in the meantime.
calling attributeLabel might give us undefined back while the request is still going and it will not be able to update.
if we wrap this in a computed function it has the chance to rerender with the updated attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a solution to not having option labels in the cart attributes. Sadly the
customAttributeMetadataquery does not support getting the option labels, howevercustomAttributeMetadataV2does. We also had to change the mapping a bit.3.x: #755