Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unicef logo #1065

Merged
merged 1 commit into from
Apr 19, 2022
Merged

fix unicef logo #1065

merged 1 commit into from
Apr 19, 2022

Conversation

pauloabreu
Copy link
Contributor

Resume

The Unicef logo in footer are breaking in some server because slashes in url:

/sitestatic//img/UNICEF_footer_Logo_black_en.png <- Broken
/sitestatic/img/UNICEF_footer_Logo_black_en.png <- Working

HAML:

%img.-ml-2(src="{{STATIC_URL}} / img/UNICEF_footer_Logo_black_en.png" class="md:-ml-0")
but {{STATIC_URL}} already have a slash, resulting in /sitestatic//img/UNICEF_footer

The Nyaruka code:

in other cases we can see this pattern: %img(src="{{STATIC_URL}}img/u-report-global-logo-white.png"), which works fine.

Reference

templates/public_base.haml:621
templates/public_base.haml:623
templates/public_base.haml:635 
templates/public_base.haml:637
ureport/settings_common.py:144

Issue: #1062

@norkans7 norkans7 merged commit 81e468c into rapidpro:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants