Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CMake 3.30.4 #834

Open
wants to merge 6 commits into
base: branch-25.04
Choose a base branch
from

Conversation

robertmaynard
Copy link

Description

Update CMake minimum required to 3.30.4 across all of RAPIDS

@robertmaynard robertmaynard added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Feb 13, 2025
Copy link

copy-pr-bot bot commented Feb 13, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @robertmaynard for updating CMake version! It looks good to me!

@robertmaynard
Copy link
Author

2025-02-19T21:14:15.9218578Z Installing collected packages: ninja, cmake, rapids-build-backend
2025-02-19T21:14:16.8634933Z   changing mode of /pyenv/versions/3.10.16/bin/ccmake to 755
2025-02-19T21:14:16.8638249Z   changing mode of /pyenv/versions/3.10.16/bin/cmake to 755
2025-02-19T21:14:16.8641804Z   changing mode of /pyenv/versions/3.10.16/bin/cpack to 755
2025-02-19T21:14:16.8645611Z   changing mode of /pyenv/versions/3.10.16/bin/ctest to 755
2025-02-19T21:14:16.9111264Z Successfully installed cmake-3.31.4 ninja-1.11.1.3 rapids-build-backend-0.3.2

2025-02-19T21:14:19.8596067Z �[1;34m2025-02-19 21:14:19 �[1;37m$ �[1;32mcp libnvjpeg-dev/usr/local/cuda-11.6/lib64/libnvjpeg_static.a /__w/cucim/cucim/temp/cuda/lib64/�[0m
2025-02-19T21:14:19.8709591Z �[1;34m2025-02-19 21:14:19 �[1;37m$ �[1;32mrm -r /tmp/tmp.p9oiW2QI2W�[0m
2025-02-19T21:14:19.8824486Z CMake Error at CMakeLists.txt:16 (cmake_minimum_required):
2025-02-19T21:14:19.8824972Z   CMake 3.30.4 or higher is required.  You are running version 3.26.5
2025-02-19T21:14:19.8825265Z 

Newest CMake version is being installed but it isn't being used since it might not have priority on the path?

@robertmaynard robertmaynard requested a review from a team as a code owner February 20, 2025 16:17
@robertmaynard
Copy link
Author

2025-02-20T16:22:15.2864940Z   changing mode of /pyenv/versions/3.10.16/bin/ccmake to 755
2025-02-20T16:22:15.2868356Z   changing mode of /pyenv/versions/3.10.16/bin/cmake to 755
2025-02-20T16:22:15.2871958Z   changing mode of /pyenv/versions/3.10.16/bin/cpack to 755
2025-02-20T16:22:15.2875404Z   changing mode of /pyenv/versions/3.10.16/bin/ctest to 755

2025-02-20T16:22:15.7520473Z 
2025-02-20T16:22:15.7520885Z �[32mRAPIDS logger�[0m » [02/20/25 16:22:15]
2025-02-20T16:22:15.7521673Z �[32m┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐�[0m
2025-02-20T16:22:15.7522960Z �[32m|    debug path '/usr/share/Modules/bin:/opt/rh/gcc-toolset-11/root/usr/bin:/pyenv/bin:/pyenv/shims:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'     |�[0m
2025-02-20T16:22:15.7524775Z �[32m└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘�[0m
2025-02-20T16:22:15.7525217Z 
2025-02-20T16:22:15.7601219Z 
2025-02-20T16:22:15.7601512Z �[32mRAPIDS logger�[0m » [02/20/25 16:22:15]
2025-02-20T16:22:15.7601944Z �[32m┌──────────────────────────────────────────┐�[0m
2025-02-20T16:22:15.7602940Z �[32m|    debug cmake path '/usr/bin/cmake'     |�[0m
2025-02-20T16:22:15.7603394Z �[32m└──────────────────────────────────────────┘�[0m
2025-02-20T16:22:15.7603624Z 

Confirmation that the pip install version of cmake isn't being used since it isn't on the path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants