Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor CUDA-accelerated find objects #837

Open
wants to merge 2 commits into
base: branch-25.04
Choose a base branch
from

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Feb 16, 2025

Include a copy of cupyx.scipy.ndimage.find_objects that was contributed upstream.

A couple of cuCIM functions that used find_objects are also updated to use this implementation instead of copying to host to call the SciPy version.

See: cupy/cupy#8916

The version vendored here is modified to exclude the Cython-based slice list comparison as we don't support using Cython code from cuCIM. This version will still provide good acceleration and we preferentially import the version from CuPy instead if it is available.

@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 16, 2025
@grlee77 grlee77 added this to the v25.04.00 milestone Feb 16, 2025
@grlee77 grlee77 requested a review from a team as a code owner February 16, 2025 16:44
update cuCIM to use GPU-based find_objects
@grlee77 grlee77 force-pushed the vendor-ndimage-find_objects branch from 83116eb to f72ba01 Compare February 16, 2025 22:07
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grlee77 for adding accelerated find_objects!
It looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants