Add missing tests - correct attribute to respect defaults

rappasoft · Sep 12, 2024 · 6cebc7f · 6cebc7f
1 parent 90900d8
commit 6cebc7f
Show file tree

Hide file tree

Showing 2 changed files with 75 additions and 17 deletions.
diff --git a/src/Traits/Core/HasCustomAttributes.php b/src/Traits/Core/HasCustomAttributes.php
@@ -21,7 +21,7 @@ public function getCustomAttributes(string $propertyName, bool $default = false,
                 return $vals;
             }
 
-            return ['default' => true, 'default-colors' => true, 'default-styling' => true];
+            return ['default' => $default, 'default-colors' => $default, 'default-styling' => $default];
         } else {
             if ($this->hasCustomAttributes($propertyName)) {
                 $vals = array_merge(['default-colors' => $default, 'default-styling' => $default], $this->{$propertyName});
@@ -30,7 +30,7 @@ public function getCustomAttributes(string $propertyName, bool $default = false,
                 return $vals;
             }
 
-            return ['default-colors' => true, 'default-styling' => true];
+            return ['default-colors' => $default, 'default-styling' => $default];
 
         }
     }

diff --git a/tests/Traits/Core/CustomAttributesTest.php b/tests/Traits/Core/CustomAttributesTest.php
@@ -3,41 +3,99 @@
 namespace Rappasoft\LaravelLivewireTables\Tests\Traits\Core;
 
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Depends;
 use Rappasoft\LaravelLivewireTables\Tests\TestCase;
+use Rappasoft\LaravelLivewireTables\Tests\Http\Livewire\PetsTable;
 
 final class CustomAttributesTest extends TestCase
 {
+
     public function test_can_get_custom_attribute_defaults_false_standard_mode(): void
     {
+        $mock = new class extends PetsTable
+        {
+            public ?array $testAttributesArray;
+
+            public function configure(): void
+            {
+                $this->setDataTableFingerprint('test');
+            }
+        };
+
+        $mock->configure();
+        $mock->boot();
+
+
         $this->assertSame([
-            'default' => false,
-            'default-colors' => true,
-            'default-styling' => true,
-        ], $this->basicTable->getCustomAttributes('bulkActionsButtonAttributes', false, true));
+            'default' => false, 
+            'default-colors' => false, 
+            'default-styling' => false
+        ], $mock->getCustomAttributes('testAttributesArray', false, true));
     }
 
     public function test_can_get_custom_attribute_defaults_false_classic_mode(): void
     {
+        $mock = new class extends PetsTable
+        {
+            public ?array $testAttributesArray;
+
+            public function configure(): void
+            {
+                $this->setDataTableFingerprint('test');
+            }
+        };
+
+        $mock->configure();
+        $mock->boot();
+
         $this->assertSame([
-            'default-colors' => true,
-            'default-styling' => true,
-        ], $this->basicTable->getCustomAttributes('bulkActionsButtonAttributes', false, false));
+            'default-colors' => false, 
+            'default-styling' => false
+        ], $mock->getCustomAttributes('testAttributesArray', false, false));
     }
 
     public function test_can_get_custom_attribute_defaults_true_standard_mode(): void
     {
+        $mock = new class extends PetsTable
+        {
+            public ?array $testAttributesArray;
+
+            public function configure(): void
+            {
+                $this->setDataTableFingerprint('test');
+            }
+        };
+
+        $mock->configure();
+        $mock->boot();
+
         $this->assertSame([
-            'default' => true,
-            'default-colors' => true,
-            'default-styling' => true,
-        ], $this->basicTable->getCustomAttributes('bulkActionsButtonAttributes', true, true));
+            'default' => true, 
+            'default-colors' => true, 
+            'default-styling' => true
+        ], $mock->getCustomAttributes('testAttributesArray', true, true));
     }
 
     public function test_can_get_custom_attribute_defaults_true_classic_mode(): void
     {
+        $mock = new class extends PetsTable
+        {
+            public ?array $testAttributesArray;
+
+            public function configure(): void
+            {
+                $this->setDataTableFingerprint('test');
+            }
+        };
+
+        $mock->configure();
+        $mock->boot();
+
         $this->assertSame([
-            'default-colors' => true,
-            'default-styling' => true,
-        ], $this->basicTable->getCustomAttributes('bulkActionsButtonAttributes', true, false));
+            'default-colors' => true, 
+            'default-styling' => true
+        ], $mock->getCustomAttributes('testAttributesArray', true, false));
     }
-}
+
+
+}