PaginationVisuals - Utilise Class Inheritance for Tests

rappasoft · Oct 1, 2024 · ebf2e09 · ebf2e09
1 parent 4bce413
commit ebf2e09
Show file tree

Hide file tree

Showing 5 changed files with 53 additions and 45 deletions.
diff --git a/tests/Traits/Visuals/Themed/BasePaginationVisuals.php b/tests/Traits/Visuals/Themed/BasePaginationVisuals.php
@@ -0,0 +1,46 @@
+<?php
+
+namespace Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed;
+
+use Rappasoft\LaravelLivewireTables\Exceptions\DataTableConfigurationException;
+
+abstract class BasePaginationVisuals extends ThemedTestCase
+{
+    abstract protected function setupBasicTableForBrowsing();
+
+    abstract protected function setupBasicTableSingleRecord();
+
+    public function pagination_shows_by_default()
+    {
+        return $this->setupBasicTableForLivewire();
+    }
+
+    public function setupSingleRecordBasicTable()
+    {
+        return $this->setupBasicTableForLivewire()
+        ->call('setPerPageAccepted', [1])
+        ->call('setPerPage', 1);
+    }
+
+    public function tableWithStandardDetailedPagination()
+    {
+        return $this->setupBasicTableSingleRecord()
+            ->call('enableDetailedPagination', 'standard');
+    }
+
+    public function tableWithSimpleDetailedPagination()
+    {
+        return $this->setupBasicTableSingleRecord()
+            ->call('enableDetailedPagination', 'simple');
+    }
+
+    public function test_per_page_dropdown_only_renders_with_accepted_values(): void
+    {
+        $this->expectException(DataTableConfigurationException::class);
+
+        $this->setupBasicTableForBrowsing()
+            ->call('setPerPage', 15);
+    }
+
+
+}
diff --git a/tests/Traits/Visuals/Themed/Bootstrap4/BS4PaginationVisualsTest.php b/tests/Traits/Visuals/Themed/Bootstrap4/BS4PaginationVisualsTest.php
@@ -2,12 +2,9 @@
 
 namespace Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\Bootstrap4;
 
-use Livewire\Livewire;
-use Rappasoft\LaravelLivewireTables\Exceptions\DataTableConfigurationException;
-use Rappasoft\LaravelLivewireTables\Tests\Http\Livewire\{PetsTable};
-use Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\ThemedTestCase;
+use Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\BasePaginationVisuals;
 
-final class BS4PaginationVisualsTest extends ThemedTestCase
+final class BS4PaginationVisualsTest extends BasePaginationVisuals
 {
     protected function setupBasicTableForBrowsing()
     {

diff --git a/tests/Traits/Visuals/Themed/Bootstrap5/BS5PaginationVisualsTest.php b/tests/Traits/Visuals/Themed/Bootstrap5/BS5PaginationVisualsTest.php
@@ -2,12 +2,9 @@
 
 namespace Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\Bootstrap5;
 
-use Livewire\Livewire;
-use Rappasoft\LaravelLivewireTables\Exceptions\DataTableConfigurationException;
-use Rappasoft\LaravelLivewireTables\Tests\Http\Livewire\{PetsTable};
-use Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\ThemedTestCase;
+use Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\BasePaginationVisuals;
 
-final class BS5PaginationVisualsTest extends ThemedTestCase
+final class BS5PaginationVisualsTest extends BasePaginationVisuals
 {
     protected function setupBasicTableForBrowsing()
     {

diff --git a/tests/Traits/Visuals/Themed/Tailwind/TWPaginationVisualsTest.php b/tests/Traits/Visuals/Themed/Tailwind/TWPaginationVisualsTest.php
@@ -2,12 +2,9 @@
 
 namespace Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\Tailwind;
 
-use Livewire\Livewire;
-use Rappasoft\LaravelLivewireTables\Exceptions\DataTableConfigurationException;
-use Rappasoft\LaravelLivewireTables\Tests\Http\Livewire\{PetsTable};
-use Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\ThemedTestCase;
+use Rappasoft\LaravelLivewireTables\Tests\Traits\Visuals\Themed\BasePaginationVisuals;
 
-final class TWPaginationVisualsTest extends ThemedTestCase
+final class TWPaginationVisualsTest extends BasePaginationVisuals
 {
     protected function setupBasicTableForBrowsing()
     {
@@ -130,14 +127,6 @@ public function test_total_results_label_doesnt_show_with_pagination_hidden(): v
         ]);
     }*/
 
-    public function test_per_page_dropdown_only_renders_with_accepted_values(): void
-    {
-        $this->expectException(DataTableConfigurationException::class);
-
-        $this->setupBasicTableForBrowsing()
-            ->call('setPerPage', 15);
-    }
-
     public function test_can_get_currently_displayed_ids(): void
     {
         $this->setupBasicTableForBrowsing()

diff --git a/tests/Traits/Visuals/Themed/ThemedTestCase.php b/tests/Traits/Visuals/Themed/ThemedTestCase.php
@@ -7,11 +7,8 @@
 use Rappasoft\LaravelLivewireTables\Tests\Http\Livewire\{PetsTable};
 use Rappasoft\LaravelLivewireTables\Tests\TestCase;
 
-abstract class ThemedTestCase extends TestCase
+class ThemedTestCase extends TestCase
 {
-    abstract protected function setupBasicTableForBrowsing();
-
-    abstract protected function setupBasicTableSingleRecord();
 
     protected function setupBasicTableForLivewire()
     {
@@ -23,22 +20,4 @@ public function pagination_shows_by_default()
         return $this->setupBasicTableForLivewire();
     }
 
-    public function setupSingleRecordBasicTable()
-    {
-        return $this->setupBasicTableForLivewire()
-            ->call('setPerPageAccepted', [1])
-            ->call('setPerPage', 1);
-    }
-
-    public function tableWithStandardDetailedPagination()
-    {
-        return $this->setupBasicTableSingleRecord()
-            ->call('enableDetailedPagination', 'standard');
-    }
-
-    public function tableWithSimpleDetailedPagination()
-    {
-        return $this->setupBasicTableSingleRecord()
-            ->call('enableDetailedPagination', 'simple');
-    }
 }