Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore hideBulkActionsWhenEmptyIsDisabled Functionality #1240

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jun 3, 2023

Enables hideBulkActionsWhenEmptyIsDisabled for the AlpineJS Approach

NOTE: This is still in testing!

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Enables hideBulkActionsWhenEmptyIsDisabled (BS4/5)

Enables hideBulkActionsWhenEmptyIsDisabled (Tailwind 2/3)

Update ChangeLog
@lrljoe lrljoe added the In Progress I've started diagnosing a fix label Jun 3, 2023
@lrljoe lrljoe self-assigned this Jun 3, 2023
@lrljoe lrljoe linked an issue Jun 3, 2023 that may be closed by this pull request
@lrljoe
Copy link
Collaborator Author

lrljoe commented Jun 3, 2023

This should be fully working, however, I'd always appreciate anyone else giving it a quick test!

@lrljoe
Copy link
Collaborator Author

lrljoe commented Jun 25, 2023

Still testing this

@lrljoe
Copy link
Collaborator Author

lrljoe commented Jul 10, 2023

Believe this is now working as it should, just needs a second pair of eyes I think!

@lrljoe lrljoe merged commit e6f7f67 into rappasoft:develop Jul 13, 2023
@lrljoe lrljoe deleted the 1239-always-show-button-bulkactions branch July 15, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress I've started diagnosing a fix
Projects
Status: Merged to Develop
Development

Successfully merging this pull request may close these issues.

Always show button (bulkActions)
2 participants