Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tk.json #1299

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Update tk.json #1299

merged 3 commits into from
Sep 1, 2023

Conversation

diat01
Copy link
Contributor

@diat01 diat01 commented Aug 13, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

diat01 and others added 3 commits June 27, 2023 22:44
@lrljoe
Copy link
Collaborator

lrljoe commented Aug 14, 2023

Thanks for the commit, I'll get this merged post V3 release, but will incorporate changes into V3 too!

@lrljoe lrljoe added the localisation Localisations/Translations label Aug 14, 2023
@lrljoe
Copy link
Collaborator

lrljoe commented Aug 25, 2023

Doing some further reviews on v3 as we've now got the v3-develop branch out, but will definitely be merging this in next weekend!

@lrljoe lrljoe added Version 2 Version 2 of Package Version 3 Version 3 of Package labels Aug 25, 2023
@lrljoe lrljoe changed the base branch from master to v2-develop September 1, 2023 00:14
@lrljoe lrljoe merged commit dfabaf7 into rappasoft:v2-develop Sep 1, 2023
9 checks passed
@lrljoe
Copy link
Collaborator

lrljoe commented Sep 1, 2023

Localisation Change - Additional PR required to add @diat01 to Localisation contribs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation Localisations/Translations Version 2 Version 2 of Package Version 3 Version 3 of Package
Projects
Status: Merged to Develop
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants