-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🚑 Fixes select all columns #1312
fix: 🚑 Fixes select all columns #1312
Conversation
Looks fine in theory to me, but I'll do some reviewing and look at whether this needs to go into the v3-develop branch too (probably will). |
Having reviewed this, I can't find an issue that this actually fixes. I'm aware of an edge where the Select All doesn't function consistently in LW3/V3 of package, but I can't replicate the issue identified in this PR in V2 of the package. If I'm missing something here, please comment or reach out on Discord! |
Can't find the issue in v2.x Have fixed it in v3.x however. @tobiashammarstrand - Can you share any video of it not working in v2? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Will review the V3 code and backport to V2, once I can replicate the issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
All Submissions:
New Feature Submissions:
Changes to Core Features:
Addresses issues with number #1276
#1276