Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🚑 Fixes select all columns #1312

Conversation

tobiashammarstrand
Copy link
Contributor

All Submissions:

  • [ x] Have you followed the guidelines in our Contributing document?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Addresses issues with number #1276
#1276

@lrljoe lrljoe changed the base branch from master to develop August 25, 2023 21:37
@lrljoe
Copy link
Collaborator

lrljoe commented Aug 25, 2023

Looks fine in theory to me, but I'll do some reviewing and look at whether this needs to go into the v3-develop branch too (probably will).
Expect this to go in next weekend to be honest, as I'm a bit washed out after v3!

@lrljoe lrljoe added Version 2 Version 2 of Package testing-fix Fix Needs Testing Version 3 Version 3 of Package labels Aug 25, 2023
@lrljoe
Copy link
Collaborator

lrljoe commented Sep 1, 2023

Having reviewed this, I can't find an issue that this actually fixes.

I'm aware of an edge where the Select All doesn't function consistently in LW3/V3 of package, but I can't replicate the issue identified in this PR in V2 of the package.

If I'm missing something here, please comment or reach out on Discord!

@lrljoe
Copy link
Collaborator

lrljoe commented Sep 3, 2023

Can't find the issue in v2.x Have fixed it in v3.x however.

@tobiashammarstrand - Can you share any video of it not working in v2?

@lrljoe lrljoe removed the Version 3 Version 3 of Package label Sep 3, 2023
@stale
Copy link

stale bot commented Oct 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 4, 2023
@lrljoe lrljoe removed the wontfix This will not be worked on label Oct 5, 2023
@lrljoe
Copy link
Collaborator

lrljoe commented Oct 5, 2023

Will review the V3 code and backport to V2, once I can replicate the issue.

Copy link

stale bot commented Nov 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 4, 2023
@stale stale bot closed this Nov 11, 2023
@lrljoe lrljoe removed the wontfix This will not be worked on label Nov 13, 2023
@lrljoe lrljoe reopened this Nov 13, 2023
@lrljoe lrljoe changed the base branch from develop to v2-develop November 13, 2023 00:11
Copy link

stale bot commented Dec 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 13, 2023
@stale stale bot closed this Dec 20, 2023
@tobiashammarstrand tobiashammarstrand deleted the fix-select-all-columns branch April 25, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing-fix Fix Needs Testing Version 2 Version 2 of Package wontfix This will not be worked on
Projects
Status: To Do
Development

Successfully merging this pull request may close these issues.

2 participants