Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to Master - V3 Fixes - Bulk Actions, Column Select, Injectors, Missing Tests #1335

Merged
merged 19 commits into from
Oct 3, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Sep 3, 2023

  • Bulk Actions Fix
  • Column Select Fix

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 4 commits August 31, 2023 22:37
…ch Options (#1324)

* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

---------

Co-authored-by: lrljoe <[email protected]>
* Update setSearchDebounce, add setSearchThrottle/setSearchBlur

* Remove Lazy Test

* Remove Lazy Tests - Update Docs

* Update Views Publish Path

* Add Translations Publish Option

* Update ChangeLog

* Add Reusable Columns

* Add Tests for Prepend/Append Cols

* Column Select Fixes

* Fix test

* Add docs for setSearchPlaceholder

* Move Filter Specific Docs ino Filter-Types

* Fix styling

* Remove extraneous space

* Adjusting Selectable Test

* Fix For BulkActions Dropdown

* Fixes for ColumnSelect

* Update ChangeLog

* Test Fix for Selectable Columns

* Remove Faulty Test

---------

Co-authored-by: lrljoe <[email protected]>
* Fix Column Select - All

* Update ChangeLog
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #1335 (6c977c4) into v3-master (4250511) will increase coverage by 3.99%.
The diff coverage is 74.34%.

@@               Coverage Diff               @@
##             v3-master    #1335      +/-   ##
===============================================
+ Coverage        83.63%   87.63%   +3.99%     
- Complexity        1133     1165      +32     
===============================================
  Files               83       83              
  Lines             2762     2862     +100     
===============================================
+ Hits              2310     2508     +198     
+ Misses             452      354      -98     
Files Coverage Δ
src/LaravelLivewireTablesServiceProvider.php 100.00% <100.00%> (ø)
src/Mechanisms/RappasoftFrontendAssets.php 93.22% <100.00%> (+46.28%) ⬆️
...Traits/Configuration/ColumnSelectConfiguration.php 100.00% <100.00%> (ø)
...c/Traits/Configuration/ReorderingConfiguration.php 100.00% <ø> (+8.10%) ⬆️
src/Traits/Configuration/SearchConfiguration.php 86.20% <100.00%> (+0.75%) ⬆️
src/Traits/Helpers/ColumnHelpers.php 94.28% <ø> (-0.21%) ⬇️
src/Traits/Helpers/ReorderingHelpers.php 100.00% <ø> (+5.55%) ⬆️
src/Traits/Helpers/SearchHelpers.php 98.14% <100.00%> (+0.07%) ⬆️
...rc/Traits/Mechanisms/WithRappasoftTableScripts.php 85.18% <100.00%> (+74.07%) ⬆️
src/Traits/Mechanisms/WithRappasoftTableStyles.php 90.47% <100.00%> (+76.19%) ⬆️
... and 10 more

... and 6 files with indirect coverage changes

lrljoe and others added 10 commits September 3, 2023 20:28
* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add NonArray setAdditionalSelects Test

* Update for FrontendAssets Test

* Add ThirdPartyScripts/Styles to Test

* Add ThirdParty Tests

* Fix AutoInjection Issue

* Fix 3rd party test

* Set default back to remote 3rd party assets

* Add CodeCov YML

* Update CodeCov - 80% minimum

* Add Filter Custom Pills Blade Test

* Fix styling

* Add formatted column test

* Column - Get Formatted Contents Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add fix for lazy loading

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add missing pagination helper tests


---------

Co-authored-by: lrljoe <[email protected]>
* Add missing component visuals tests & failed tables

* Update Exception Expectation

* Temporary test swapping to check Exception throwing

---------

Co-authored-by: lrljoe <[email protected]>
* Add setSearchFieldAttribute Options


---------

Co-authored-by: lrljoe <[email protected]>
* ColumnSelect Fixes - Phase 1

* Update "Select All" to use counts

* Missing closing bracket

* All Are Selected -> Move to method in Helpers

* ColSelectFixes

* Ensure event fires

* Update ColumnsSelectedTest

* Fix superfluous empty array return

* Remove superfluous default return

* Adjust Tests - Include Coverage For ExcludeDeselectedCols

* Add Tests For AllColsSelected

* Fix styling

* Fixes for Deselected Cols

* Fix styling

* Updates to Changelog

* Removing ColumnSelected Event Test - Temporary

* Add default true to replace removed test

* Add improved test

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe changed the title Develop to Master - Bulk Actions & Column Select Fixes Develop to Master - V3 Fixes - Bulk Actions, Column Select, Injectors, Missing Tests Sep 23, 2023
lrljoe and others added 5 commits September 23, 2023 04:20
* Check for "original" property

* Adjusting order of request validations

* Updates to Asset Injection Methods

* Fix assertViewIs is not working (#67)
Contribs By: Jackson Tong <[email protected]

* Tweaks for Auto Injection Options

* Test Updates - Frontend Assets

* Add ThirdParty Basic Header Tests

* Add Initial Debuggable DTO Test
* Reordering Fixes - Performance & Toggling

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add All Option

* Update Import Paths

* Add minified CSS Versions
* Add setTrAttributes back into use

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe
Copy link
Collaborator Author

lrljoe commented Oct 3, 2023

Merging Develop to Master

@lrljoe lrljoe closed this Oct 3, 2023
@lrljoe lrljoe reopened this Oct 3, 2023
@lrljoe lrljoe merged commit 003ab4a into v3-master Oct 3, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants