Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Blades - Reduce use of directly referenced variables #1918

Closed

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Sep 1, 2024

Clean Up Blades

This PR is to assist with longer-term support of published blades.

  • Use ComputedProperties rather than Direct References
  • Reduce use of any direct references

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (0c8ec45) to head (cd62162).
Report is 79 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1918      +/-   ##
=================================================
+ Coverage          87.30%   88.08%   +0.78%     
- Complexity          1672     1815     +143     
=================================================
  Files                150      168      +18     
  Lines               3891     4180     +289     
=================================================
+ Hits                3397     3682     +285     
- Misses               494      498       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe changed the title Remove $component References Clean Up Blades - Reduce use of directly referenced variables Sep 1, 2024
@lrljoe
Copy link
Collaborator Author

lrljoe commented Sep 1, 2024

Actually ends up slower

@lrljoe lrljoe closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant