Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JUnit to tests the programs #82

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

dullin
Copy link
Collaborator

@dullin dullin commented Aug 15, 2024

Refactored the run method from RarsTest into a testFile method for RarsUnitTest. Converted the text returns into asserts.

Renamed the risc-tests to risc-tests-32 to be more explicit. Moved the licence information to the global licence file.

The checkBinary and checkPseudo are still in the old version, so this is still a draft.

Discussion topics:

  • Should we ditch RarsTest if we complete RarsUnitTest
    • Pros : Single file for testing
    • Cons : Now requires JUnit for testing

Copy link

github-actions bot commented Aug 15, 2024

Test Results

  4 files   -   8    4 suites   - 8   28s ⏱️ -7s
167 tests +159  163 ✅ +155  0 💤 ±0  4 ❌ +4 
167 runs  +143  163 ✅ +139  0 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 4d196df. ± Comparison against base commit a94fdec.

This pull request removes 1 and adds 160 tests. Note that renamed tests count towards both.
RarsUnitTest ‑ checkPrograms
RarsUnitTest ‑ testRunRV32(String)[10]
RarsUnitTest ‑ testRunRV32(String)[11]
RarsUnitTest ‑ testRunRV32(String)[12]
RarsUnitTest ‑ testRunRV32(String)[13]
RarsUnitTest ‑ testRunRV32(String)[14]
RarsUnitTest ‑ testRunRV32(String)[15]
RarsUnitTest ‑ testRunRV32(String)[16]
RarsUnitTest ‑ testRunRV32(String)[17]
RarsUnitTest ‑ testRunRV32(String)[18]
RarsUnitTest ‑ testRunRV32(String)[19]
…

♻️ This comment has been updated with latest results.

@privat
Copy link
Collaborator

privat commented Aug 16, 2024

test-32 is good and should be PRed independently for a fast integration
same for the license thing, this could be in another PR

About ditching RarsTest, I like having it a separate tool, that take parameters and that you can run on your own sample programs.
A better approach anyway could be to integrate in into the main rars tool see #84

@dullin dullin force-pushed the junit-check-program branch from 7269218 to 405efdb Compare August 20, 2024 14:47
@dullin dullin force-pushed the junit-check-program branch from 405efdb to 4d196df Compare August 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants