New libav integration using PyAv through the PyavOutput class #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PyavOutput gives us direct access to libav without having to route everything to a separate FFmpeg process. This lets us pass precise timestamps. Rewrite CircularOutput to create CircularOutput2. The new one accepts an "output" object and is not derived from FileOutput. Thus it can be used in conjunction with the PyavOutput. Signed-off-by: David Plowman <[email protected]>
Plus a few other miscellaneous fixes, and also a new streaming example. Signed-off-by: David Plowman <[email protected]>
This also provides a route to using the PyavOutput. Signed-off-by: David Plowman <[email protected]>
Make the PyavOutput work with existing non-libav encoders that don't pass a "packet" - so instead we have to make one up. Signed-off-by: David Plowman <[email protected]>
davidplowman
force-pushed
the
pyav-output
branch
from
a88056f
to
6ca39f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit experimental, but integrates Picamera2 more closely with libav, without the need to pipe stuff out to a separate FFmpeg process.
There are quite a few benefits. We can pass precise timestamps and can avoid all the irritating timestamp warnings caused by FFmpeg resampling the wallclock. I've had to add audio processing via an encoder thread in the base
Encoderclass, but this even enables us to do things like time-shifted recordings with audio, straight to mp4 files.It's very versatile which means I'm sure we'll find some niggles down the line was we use it, but it already feels quite useful.