picamera2: Allow setting of stride #892
Conversation
| if stream_config.get("stride") is not None: | ||
| libcamera_stream_config.stride = stream_config["stride"] | ||
| else: | ||
| libcamera_stream_config.stride = 0 |
There was a problem hiding this comment.
Would libcamera_stream_config.stride = stream_config.get("stride", 0) be the same?
There was a problem hiding this comment.
Oh yes, that'll be cleaner, I'll change that and push a new commit
|
Thanks for this Will - are we happy that is doesn't rely on any other libcamera/libpisp changes? (The tests all pass, so presumably not...) |
will-v-pi
force-pushed
the
stride-fixes
branch
from
098f0ca
to
dc4be4e
Compare
|
It does rely on a libpisp and libcamera change, but that's only to get it to actually set the stride, so worth merging it now in anticipation of those changes being merged, as once the libcamera change is merged it'll break picamera2 (because it's accidentally setting an incorrect stride, which is currently ignored but if it's not ignored then it'll break). Without those changes it'll just do nothing when you set the stride, it won't break or anything. |
|
The tests seem to have got very unhappy, do we know what that's about? I can't believe that teeny tweak would have caused it...! |
Allow setting of the stride in stream configuration, and default to 0 if not set to allow libcamera to set the correct stride. Signed-off-by: William Vinnicombe <[email protected]>
will-v-pi
force-pushed
the
stride-fixes
branch
from
dc4be4e
to
325f794
Compare
|
It seems the stream_config sometimes has the stride set to None, so that was causing things to break - I've gone back to the original code which guarded against that case, but added a comment to say why |
Allow setting of the stride in stream configuration, and default to 0 if not set to allow libcamera to set the correct stride.