Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store multiplexer #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Jan 24, 2025

What this PR does / why we need it:

This PR introduces a multiplexer for stores.
The multiplexer is intended to be used when specifical stores are required for certain registries.

Which issue(s) this PR resolves

Related to #19, #26, #30.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 90.69767% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
store_mux.go 90.69% 8 Missing and 4 partials ⚠️
Files with missing lines Coverage Δ
store_mux.go 90.69% <90.69%> (ø)

@shizhMSFT
Copy link
Contributor Author

shizhMSFT commented Jan 26, 2025

Examples for typical scenarios like mixing [OCIStore] and [RegistryStore] will be added in later PRs as it depends on #30.
One interesting use case is to use the multiplexer for special registries like localhost and those registries require client-cert auth.

@shizhMSFT shizhMSFT marked this pull request as ready for review January 26, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant