Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci.yml: Use boolean for debug input #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rindeal
Copy link
Contributor

@rindeal rindeal commented May 23, 2024

This is just a tiny fix that converts the boolean choice input into a proper boolean type.

@DariuszPorowski DariuszPorowski self-requested a review May 26, 2024 16:42
Copy link
Contributor

@DariuszPorowski DariuszPorowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rindeal actually this one is intentionally, type choice gives a form style way for manual trigger:

image

@rindeal
Copy link
Contributor Author

rindeal commented Jun 10, 2024

How is a dropdown better than a checkbox for a boolean? It even requires one more click to select. I fail to see the benefits of such a divergence from norms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants