Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
yangwwei committed Sep 27, 2024
1 parent 31ade1c commit d932703
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ func TestPopulateGangSchedulingAnnotations(t *testing.T) {
rayPod := createPod("ray-pod", "default")
yk.populateTaskGroupsAnnotationToPod(rayClusterWithGangScheduling, rayPod)

kk, err := GetTaskGroupsFromAnnotation(rayPod)
kk, err := getTaskGroupsFromAnnotation(rayPod)
assert.NoError(t, err)
assert.Equal(t, len(kk), 2)
// verify the annotation value
Expand Down Expand Up @@ -247,7 +247,7 @@ func podLabelsContains(pod *v1.Pod, key string, value string) bool {
return false
}

func GetTaskGroupsFromAnnotation(pod *v1.Pod) ([]TaskGroup, error) {
func getTaskGroupsFromAnnotation(pod *v1.Pod) ([]TaskGroup, error) {
taskGroupInfo, exist := pod.Annotations[YuniKornTaskGroupsAnnotationName]
if !exist {
return nil, fmt.Errorf("not found")
Expand Down

0 comments on commit d932703

Please sign in to comment.