Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kustomization files to Kustomize v5 #2352

Merged
merged 1 commit into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apiserver/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ GOBINDATA ?= $(REPO_ROOT_BIN)/go-bindata


## Tool Versions
KUSTOMIZE_VERSION ?= v3.8.7
KUSTOMIZE_VERSION ?= v5.4.3
GOFUMPT_VERSION ?= v0.3.1
GOIMPORTS_VERSION ?= v0.14.0
GOLANGCI_LINT_VERSION ?= v1.54.1
Expand Down
8 changes: 5 additions & 3 deletions apiserver/deploy/base/insecure/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ namespace: ray-system
resources:
- apiserver.yaml

commonLabels:
app.kubernetes.io/name: kuberay
app.kubernetes.io/component: kuberay-apiserver
images:
- name: kuberay/apiserver
newName: kuberay/apiserver
newTag: nightly
labels:
- includeSelectors: true
pairs:
app.kubernetes.io/component: kuberay-apiserver
app.kubernetes.io/name: kuberay
8 changes: 5 additions & 3 deletions apiserver/deploy/base/secure/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ namespace: ray-system
resources:
- apiserver.yaml

commonLabels:
app.kubernetes.io/name: kuberay
app.kubernetes.io/component: kuberay-apiserver
images:
- name: kuberay/apiserver
newName: kuberay/apiserver
newTag: nightly
- name: kuberay/security-proxy
newName: kuberay/security-proxy
newTag: nightly
labels:
- includeSelectors: true
pairs:
app.kubernetes.io/component: kuberay-apiserver
app.kubernetes.io/name: kuberay
10 changes: 5 additions & 5 deletions apiserver/deploy/local/insecure/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ kind: Kustomization
resources:
- ../../base/insecure
namespace: ray-system
patchesJson6902:
images:
- name: kuberay/apiserver
newName: quay.io/kuberay/apiserver
newTag: latest
patches:
- patch: |-
- op: replace
path: /spec/template/spec/containers/0/imagePullPolicy
Expand All @@ -12,7 +16,3 @@ patchesJson6902:
kind: Deployment
name: kuberay-apiserver
version: v1
images:
- name: kuberay/apiserver
newName: quay.io/kuberay/apiserver
newTag: latest
16 changes: 8 additions & 8 deletions apiserver/deploy/local/secure/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@ kind: Kustomization
resources:
- ../../base/secure
namespace: ray-system
patchesJson6902:
images:
- name: kuberay/apiserver
newName: kuberay/apiserver
newTag: latest
- name: kuberay/security-proxy
newName: kuberay/security-proxy
newTag: latest
patches:
- patch: |-
- op: replace
path: /spec/template/spec/containers/0/imagePullPolicy
Expand All @@ -15,10 +22,3 @@ patchesJson6902:
kind: Deployment
name: kuberay-apiserver
version: v1
images:
- name: kuberay/apiserver
newName: kuberay/apiserver
newTag: latest
- name: kuberay/security-proxy
newName: kuberay/security-proxy
newTag: latest
2 changes: 2 additions & 0 deletions ray-operator/config/certmanager/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ resources:

configurations:
- kustomizeconfig.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
3 changes: 2 additions & 1 deletion ray-operator/config/crd/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ resources:
- bases/ray.io_rayclusters.yaml
- bases/ray.io_rayservices.yaml
- bases/ray.io_rayjobs.yaml
# +kubebuilder:scaffold:crdkustomizeresource
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
6 changes: 3 additions & 3 deletions ray-operator/config/default-with-webhooks/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ images:
newName: quay.io/kuberay/operator
newTag: nightly

patchesStrategicMerge:
- manager_webhook_patch.yaml
- webhookcainjection_patch.yaml

replacements:
- source:
Expand Down Expand Up @@ -125,3 +122,6 @@ resources:
- ../webhook
- ../certmanager
- namespace.yaml
patches:
- path: manager_webhook_patch.yaml
- path: webhookcainjection_patch.yaml
12 changes: 7 additions & 5 deletions ray-operator/config/default/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,17 @@ namespace: ray-system
#commonLabels:
# someName: someValue

oksanabaza marked this conversation as resolved.
Show resolved Hide resolved
bases:
- ../crd
- ../rbac
- ../manager
- namespace.yaml
# [PROMETHEUS] To enable prometheus monitor, uncomment all sections with 'PROMETHEUS'.
#- ../prometheus

images:
- name: kuberay/operator
newName: quay.io/kuberay/operator
newTag: nightly
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../crd
- ../rbac
- ../manager
- namespace.yaml
8 changes: 5 additions & 3 deletions ray-operator/config/manager/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ resources:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

commonLabels:
app.kubernetes.io/component: kuberay-operator
app.kubernetes.io/name: kuberay
labels:
- includeSelectors: true
pairs:
app.kubernetes.io/component: kuberay-operator
app.kubernetes.io/name: kuberay
10 changes: 7 additions & 3 deletions ray-operator/config/rbac/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ resources:
- leader_election_role_binding.yaml
- service_account.yaml

oksanabaza marked this conversation as resolved.
Show resolved Hide resolved
commonLabels:
app.kubernetes.io/name: kuberay
app.kubernetes.io/component: kuberay-operator
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
labels:
- includeSelectors: true
pairs:
app.kubernetes.io/component: kuberay-operator
app.kubernetes.io/name: kuberay
2 changes: 2 additions & 0 deletions ray-operator/config/webhook/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@ patches:
kind: ValidatingWebhookConfiguration
name: validating-webhook-configuration
version: v1
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
Loading