Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup.py develop for installation #397

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

rshin
Copy link
Contributor

@rshin rshin commented Sep 2, 2016

This should have the same effect as updating PYTHONPATH. I suppose all the other install-*.md would need to be updated too...

@robertnishihara
Copy link
Collaborator

robertnishihara commented Sep 2, 2016

Nice! This is cleaner for deployment, but a little more work during development, right (because it's no longer enough to recompile, you also have to rerun setup.py)? That's probably the right tradeoff though.

In addition to updating the other installation documents, could you also update the .travis.yml and dockerfiles to reflect this new workflow? And maybe remove the setup-env.sh file as well.

@pcmoritz
Copy link
Collaborator

pcmoritz commented Sep 2, 2016

Richard pointed out to me that there is python setup.py develop which does what we want for development (i.e. you don't need to re-run python setup.py if you edit the source), see http://stackoverflow.com/questions/19048732/python-setup-py-develop-vs-install

+1 for switching to this workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants