Skip to content

Commit

Permalink
[dashboard] Bugfix: add back DashboardHead.gcs_aio_client. (#49855) (#…
Browse files Browse the repository at this point in the history
…49862)

Cherry picks #49855.

Signed-off-by: Ruiyang Wang <[email protected]>
  • Loading branch information
rynewang authored Jan 15, 2025
1 parent ea642f6 commit 021baf7
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions python/ray/dashboard/head.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,16 +260,16 @@ async def run(self):
gcs_address = self.gcs_address

# Dashboard will handle connection failure automatically
gcs_client = GcsClient(
self.gcs_client = GcsClient(
address=gcs_address, nums_reconnect_retry=0, cluster_id=self.cluster_id_hex
)
gcs_aio_client = GcsAioClient(
self.gcs_aio_client = GcsAioClient(
address=gcs_address, nums_reconnect_retry=0, cluster_id=self.cluster_id_hex
)
internal_kv._initialize_internal_kv(gcs_client)
internal_kv._initialize_internal_kv(self.gcs_client)

if not self.minimal:
self.metrics = await self._setup_metrics(gcs_aio_client)
self.metrics = await self._setup_metrics(self.gcs_aio_client)

try:
assert internal_kv._internal_kv_initialized()
Expand Down Expand Up @@ -320,13 +320,13 @@ async def _async_notify():
# This could be done better in the future, including
# removing the polling on the Ray side, by communicating the
# server address to Ray via stdin / stdout or a pipe.
gcs_client.internal_kv_put(
self.gcs_client.internal_kv_put(
ray_constants.DASHBOARD_ADDRESS.encode(),
f"{dashboard_http_host}:{http_port}".encode(),
True,
namespace=ray_constants.KV_NAMESPACE_DASHBOARD,
)
gcs_client.internal_kv_put(
self.gcs_client.internal_kv_put(
dashboard_consts.DASHBOARD_RPC_ADDRESS.encode(),
f"{self.ip}:{self.grpc_port}".encode(),
True,
Expand Down

0 comments on commit 021baf7

Please sign in to comment.