Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Update docs on max ongoing requests default change #46414

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Jul 3, 2024

[serve] Update docs on max ongoing requests default change

When changing the default for max_ongoing_requests from 100 to 5, the autoscaling docs were updated but the "Configure Serve Deployment" docs were missed.
Update configure serve deployment docs with the new default value.

Signed-off-by: Cindy Zhang [email protected]

@zcin zcin marked this pull request as ready for review July 3, 2024 17:06
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cindy!

@shrekris-anyscale shrekris-anyscale added the go add ONLY when ready to merge, run all tests label Jul 9, 2024
@zcin
Copy link
Contributor Author

zcin commented Jul 16, 2024

@shrekris-anyscale @edoakes ping for merge

@edoakes
Copy link
Contributor

edoakes commented Jul 16, 2024

@zcin merge conflict now

When changing the default for `max_ongoing_requests` from 100 to 5, the autoscaling docs were updated but the "Configure Serve Deployment" docs were missed.
Update configure serve deployment docs with the new default value.


Signed-off-by: Cindy Zhang <[email protected]>
@zcin
Copy link
Contributor Author

zcin commented Jul 16, 2024

@edoakes fixed merge conflict

@shrekris-anyscale shrekris-anyscale merged commit 9a3cd8a into ray-project:master Jul 16, 2024
6 checks passed
@zcin zcin deleted the pr46414 branch August 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants