[RLlib] Fix 2 broken CI tests. #47993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
sven1977
commented
Oct 11, 2024
| @@ -95,9 +90,6 @@ def tearDownClass(cls) -> None: | |||
| def test_save_appo_multi_agent(self): | |||
| save_test("APPO", "torch", multi_agent=True) | |||
|
|
|||
| def test_save_ppo(self): | |||
There was a problem hiding this comment.
new API stack: Already covered extensively (including extracting RLModule checkpoint and testing it) in checkpoints/ subfolder of the example scripts.
sven1977
commented
Oct 11, 2024
| @@ -1343,13 +1343,6 @@ py_test( | |||
| # | |||
| # Tag: evaluation | |||
| # -------------------------------------------------------------------- | |||
| py_test( | |||
There was a problem hiding this comment.
Moved the important test therein into test_env_runner_failures.
All other tests therein are redundant and are scenarios are already covered in test_env_runner_failures!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2 broken CI tests.
test_env_runner_failures, which already covers all scenarios that were intest_envs_that_crash)Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.