Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore][Core] Address PR 47807 comments #48002

Merged
merged 1 commit into from
Oct 12, 2024
Merged

[Chore][Core] Address PR 47807 comments #48002

merged 1 commit into from
Oct 12, 2024

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

PR 47807 was auto-merged without applying the doc reviews, so this commit addresses them.

#47807 (review)

Related issue number

Related to #47807

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness
[Chore][Core] Address PR 47807 comments
7c8bdc4 
PR 47807 was auto-merged without applying the doc reviews, so this
commit addresses them.

Signed-off-by: Chi-Sheng Liu <[email protected]>
@rynewang rynewang enabled auto-merge (squash) October 12, 2024 18:18
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 12, 2024
@rynewang rynewang merged commit 1ae9025 into ray-project:master Oct 12, 2024
5 of 6 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@MortalHappiness @ujjawal-khare
[Chore][Core] Address PR 47807 comments (ray-project#48002)
46cd4c6 
PR 47807 was auto-merged without applying the doc reviews, so this
commit addresses them.

Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@MortalHappiness @ujjawal-khare
[Chore][Core] Address PR 47807 comments (ray-project#48002)
060fb10 
PR 47807 was auto-merged without applying the doc reviews, so this
commit addresses them.

Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@MortalHappiness @ujjawal-khare
[Chore][Core] Address PR 47807 comments (ray-project#48002)
0b4bf3c 
PR 47807 was auto-merged without applying the doc reviews, so this
commit addresses them.

Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@MortalHappiness @ujjawal-khare
[Chore][Core] Address PR 47807 comments (ray-project#48002)
aa45831 
PR 47807 was auto-merged without applying the doc reviews, so this
commit addresses them.

Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@MortalHappiness @ujjawal-khare
[Chore][Core] Address PR 47807 comments (ray-project#48002)
92eaf1c 
PR 47807 was auto-merged without applying the doc reviews, so this
commit addresses them.

Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynewang rynewang rynewang approved these changes

@angelinalg angelinalg Awaiting requested review from angelinalg

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MortalHappiness @rynewang