[Style] update flake8 to latest and update requirements #48023
+54
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheyu Wu <[email protected]>
CheyuWu
requested review from
hongpeng-guo,
justinvyu,
matthewdeng,
raulchen,
woshiyyya and
a team
as code owners
…an unexpected keyword argument 'unsafe_hash'. Signed-off-by: Cheyu Wu <[email protected]>
aslonnie
reviewed
Oct 15, 2024
| flake8-comprehensions==3.10.1, | ||
| flake8-quotes==2.0.0, | ||
| flake8-comprehensions==3.15.0, | ||
| flake8-quotes==3.4.0, |
There was a problem hiding this comment.
you need to upgrade bugbear too, and update the python/requirements_copmiled.txt file
here is an example of the dependency update of flake (without the additional ignore list though).
There was a problem hiding this comment.
OK, no problem. Thanks for your advice
Signed-off-by: Cheyu Wu <[email protected]>
….txt Signed-off-by: Cheyu Wu <[email protected]>
aslonnie
reviewed
Oct 15, 2024
python/requirements_compiled.txt
Outdated
| @@ -521,17 +521,21 @@ filelock==3.13.1 | |||
| # torch | |||
| # transformers | |||
| # virtualenv | |||
| flake8==3.9.1 | |||
| flake8==7.1.1; python_version > '3.8' | |||
| flake8==3.9.1; python_version <= '3.8' | |||
There was a problem hiding this comment.
we do not support <=3.8 anymore. can you just remove those?
There was a problem hiding this comment.
Well, The pipeline will be checked for Python 3.8.
I'm not sure how to resolve this issue since the CI pipeline will pull Python 3.8.
Signed-off-by: Cheyu Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #48022
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.cc @MortalHappiness