[core] Return failure for failed runtime env dereference #50003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/return-failure-for-deref
branch
from
8141739 to
9215e16
Compare
rynewang
reviewed
Jan 23, 2025
dentiny
force-pushed
the
hjiang/return-failure-for-deref
branch
2 times, most recently
from
96b8df7 to
4cd4f7c
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/return-failure-for-deref
branch
from
4cd4f7c to
ae4fa80
Compare
rynewang
reviewed
Jan 24, 2025
Signed-off-by: dentiny <[email protected]>
…ray into hjiang/return-failure-for-deref
rynewang
approved these changes
Jan 24, 2025
erictang000
pushed a commit
to erictang000/ray
that referenced
this pull request
Jan 27, 2025
…#50003) Dereference is not supposed to fail, if only warning message is logged, it's hard to detected failed precondition. --------- Signed-off-by: dentiny <[email protected]> Signed-off-by: Eric Tang <[email protected]>
srinathk10
pushed a commit
that referenced
this pull request
Feb 2, 2025
Dereference is not supposed to fail, if only warning message is logged, it's hard to detected failed precondition. --------- Signed-off-by: dentiny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dereference is not supposed to fail, if only warning message is logged, it's hard to detected failed precondition.