[dashboard] Remove the dashboard grpc server. #50021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
rynewang
requested review from
richardliaw,
rkooo567,
jjyao and
a team
as code owners
|
Note: we can do similar things to remove agent grpc as well: they can all be replaced by http. Not in this PR though. |
|
That would be tremendous if we can get rid of the python grpc dependency from ray[default] going forward! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #50020.
After that PR, the Dashboard does not hold any service on its grpc server. We may as well just remove the whole concept. Removing all references to dashboard_grpc_address, spare the only CLI argument in
ray startwhich we just ignore, because that's the public API and we don't want to break user scripts.