-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][compiled graphs] Support experimental_compile(_default_communicator=comm) #50023
Open
ruisearch42
wants to merge
24
commits into
ray-project:master
Choose a base branch
from
ruisearch42:explicit_comm2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+321
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
ruisearch42
changed the title
wip
[core][compiled graphs] Support Support experimental_compile(_default_communicator=comm)
Jan 23, 2025
Signed-off-by: Rui Qiao <[email protected]>
ruisearch42
force-pushed
the
explicit_comm2
branch
from
January 24, 2025 02:40
82bd905
to
3a568e4
Compare
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
ruisearch42
changed the title
[core][compiled graphs] Support Support experimental_compile(_default_communicator=comm)
[core][compiled graphs] Support experimental_compile(_default_communicator=comm)
Jan 30, 2025
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
kevin85421
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently,
with_tensor_transport(transport=arg)
supports 3 types of arg: "nccl", "auto", or aCommunicator
. If "nccl" is used, or "auto" is used and resolves to using NCCL, Ray creates a communicator internally and uses it.In order to better manage the communicator lifecycle, we make the following changes:
experimental_compile(_default_communicator=default_comm)
, default_comm is a default communicator user provided_default_communicator
in the above API can be "create", which explicitly tells Ray to create a default communicator and use it for allwith_tensor_transport()
sites where a specific communicator was not provided_default_communicator
is not specified, Ray will not create a default communicator or reuse communicators passed in from otherwith_tensor_transport()
sites, but throw an error when a communicator is needed. Note that this is backward incompatible._init_communicator()
is called for all communicators (passed in or created) on its involved actors, and_destroy_communicator()
is only called for the ones created by Compiled Graph.By default,
experimental_compile(_default_communicator="create")
is used, therefore:with_tensor_transport()
for p2p, andcollective.allreduce.bind()
for collective) will take precedence and be used in the corresponding operations. These communicators won't be reused at other sites. (User should explicitly specify if they want.)This PR also refactors
CompiledDAG._preprocess()
so that code is more organized.Related issue number
Closes #47540
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.