Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve][doc] update serve vllm openai example for latest vllm version #50047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erictang000
Copy link

@erictang000 erictang000 commented Jan 23, 2025

Why are these changes needed?

https://docs.ray.io/en/latest/serve/tutorials/vllm-example.html - Currently doesn't work out of the box for the latest vllm versions.

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@erictang000 erictang000 changed the title update serve vllm openai example for latest vllm version [serve][doc] update serve vllm openai example for latest vllm version Jan 23, 2025
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric!

@jcotant1 jcotant1 added the serve Ray Serve Related Issue label Jan 23, 2025
@zcin
Copy link
Contributor

zcin commented Jan 24, 2025

@erictang000 You can fix the DCO by running git commit -s --amend --no-edit on your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serve Ray Serve Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants