Report unicode strings as is for python2.7

rayyansys · Dec 28, 2023 · 0296a52 · 0296a52
1 parent 4d46902
commit 0296a52
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pyworker/reporter.py b/pyworker/reporter.py
@@ -64,7 +64,8 @@ def _to_camel_case(string):
 
     @staticmethod
     def _convert_value(value):
-        if type(value) not in [str, int, float, bool]:
+        # unicode is needed in python2.7 only, otherwise it raises an error
+        if type(value) not in [str, int, float, bool, unicode]:
             return json.dumps(value)
         return value
 

diff --git a/tests/test_reporter.py b/tests/test_reporter.py
@@ -110,6 +110,7 @@ def test_reporter_format_attributes_prefixes_and_camel_cases_keys_and_converts_v
         self.assertEqual(
             reporter._format_attributes({
                 'test_key1': 'test_value1',
+                'test_key1b': u'test_value1b', # specific to python 2.7
                 'test_key2': 2,
                 'test_key3': 3.0,
                 'test_key4': True,
@@ -119,6 +120,7 @@ def test_reporter_format_attributes_prefixes_and_camel_cases_keys_and_converts_v
             }),
             {
                 'prefix.testKey1': 'test_value1',
+                'prefix.testKey1B': u'test_value1b', # specific to python 2.7
                 'prefix.testKey2': 2,
                 'prefix.testKey3': 3.0,
                 'prefix.testKey4': True,
@@ -157,6 +159,11 @@ def test_reporter_convert_value_converts_value_to_json_if_not_supported(self):
             reporter._convert_value('test_value'),
             'test_value'
         )
+        # specific to python 2.7
+        self.assertEqual(
+            reporter._convert_value(u'test_value'),
+            u'test_value'
+        )
         self.assertEqual(
             reporter._convert_value(1),
             1