Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dropdown, Popover): use surface.popup.background token as background #1753

Merged
merged 14 commits into from
Oct 31, 2023
Merged

fix(Dropdown, Popover): use surface.popup.background token as background #1753

merged 14 commits into from
Oct 31, 2023

Conversation

saurabhdaware
Copy link
Member

@saurabhdaware saurabhdaware commented Oct 26, 2023 •
edited
Loading

Dropdown

  • Change DropdownOverlay to use popup.background token

Popover

  • Remove hardcoded values
  • Use popup.background token

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 61eb003

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

Image description CodeRabbit

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

github-actions[bot]
github-actions bot reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 35ac636 and 01e1b18 commits.
Files selected (1)
  • packages/blade/src/components/Dropdown/StyledDropdownOverlay.tsx (1)
Files skipped from review due to trivial changes (1)
  • packages/blade/src/components/Dropdown/StyledDropdownOverlay.tsx
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@bundlemon
Copy link

bundlemon bot commented Oct 26, 2023 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ React Native Components
build/components/index.native.js
 185.92KB (-75B -0.04%) -
✅ Web Components
build/components/index.production.web.js
 259.97KB (-82B -0.03%) -
Unchanged files (12)
Status Path Size Limits
✅ Web Tokens
build/tokens/index.production.web.js
 42.24KB -
✅ React Native Tokens
build/tokens/index.native.js
 38.35KB -
✅ CSS Theme Tokens
build/css/paymentThemeDarkDesktop.css
 4.55KB -
✅ CSS Theme Tokens
build/css/paymentThemeDarkMobile.css
 4.54KB -
✅ CSS Theme Tokens
build/css/bankingThemeLightDesktop.css
 4.53KB -
✅ CSS Theme Tokens
build/css/bankingThemeLightMobile.css
 4.52KB -
✅ CSS Theme Tokens
build/css/bankingThemeDarkDesktop.css
 4.52KB -
✅ CSS Theme Tokens
build/css/paymentThemeLightDesktop.css
 4.52KB -
✅ CSS Theme Tokens
build/css/bankingThemeDarkMobile.css
 4.51KB -
✅ CSS Theme Tokens
build/css/paymentThemeLightMobile.css
 4.51KB -
✅ Web Utils
build/utils/index.production.web.js
 3.29KB -
✅ React Native Utils
build/utils/index.native.js
 2.26KB -

Total files change -157B -0.03%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 26, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 61eb003:

Sandbox Source
razorpay/blade: basic Configuration

@saurabhdaware saurabhdaware changed the base branch from master to touch-lumber October 27, 2023 12:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

✅ PR title follows Conventional Commits specification.

rzpcibot and others added 6 commits October 27, 2023 17:51
@rzpcibot
Merge branch 'touch-lumber' of github.com:razorpay/blade into feat/dr…
ab24a7e 
…opdownoverlay-token
@rzpcibot
feat(tokens): add new tokens
b3d1d48
@rzpcibot
fix: remove old changes
3dbb1b8
@rzpcibot
fix: remove npmrc
49e1e44
@saurabhdaware @rzpcibot
feat: migrate overlay tokens (#1772)
54afad8 
* feat: migrate overlay token

* Create honest-glasses-sin.md

* empty commit

* test: update snapshots

* docs: changeset rephrasing

---------

Co-authored-by: rzpcibot <[email protected]>
@saurabhdaware
fix: conflicts
6cbab46
@saurabhdaware saurabhdaware changed the base branch from touch-lumber to follow-smoke October 31, 2023 08:13
github-actions[bot]
github-actions bot reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 01e1b18 and 68b51bf commits.
Files selected (8)
  • packages/blade/src/components/Popover/Popover.native.tsx (3)
  • packages/blade/src/components/Popover/Popover.web.tsx (3)
  • packages/blade/src/components/Popover/PopoverContent.tsx (2)
  • packages/blade/src/components/Popover/PopoverContentWrapper.native.tsx (2)
  • packages/blade/src/components/Popover/PopoverContentWrapper.web.ts (1)
  • packages/blade/src/components/Popover/constants.ts (1)
  • packages/blade/src/components/Popover/getPopoverContentWrapperStyles.ts (1)
  • packages/blade/src/components/Popover/types.ts (2)
Files ignored due to filter (4)
  • packages/blade/src/components/Dropdown/tests/snapshots/Dropdown.ssr.test.tsx.snap
  • packages/blade/src/components/Dropdown/tests/snapshots/Dropdown.web.test.tsx.snap
  • packages/blade/src/components/Input/DropdownInputTriggers/tests/snapshots/AutoComplete.ssr.test.tsx.snap
  • packages/blade/src/components/Input/DropdownInputTriggers/tests/snapshots/AutoComplete.web.test.tsx.snap
Files not summarized due to errors (4)
  • packages/blade/src/components/Popover/PopoverContent.tsx (nothing obtained from openai)
  • packages/blade/src/components/Popover/PopoverContentWrapper.web.ts (nothing obtained from openai)
  • packages/blade/src/components/Popover/PopoverContentWrapper.native.tsx (nothing obtained from openai)
  • packages/blade/src/components/Popover/getPopoverContentWrapperStyles.ts (nothing obtained from openai)
Files not reviewed due to errors (4)
  • packages/blade/src/components/Popover/getPopoverContentWrapperStyles.ts (no response)
  • packages/blade/src/components/Popover/PopoverContentWrapper.native.tsx (no response)
  • packages/blade/src/components/Popover/PopoverContentWrapper.web.ts (no response)
  • packages/blade/src/components/Popover/PopoverContent.tsx (no response)
Files skipped from review due to trivial changes (4)
  • packages/blade/src/components/Popover/Popover.native.tsx
  • packages/blade/src/components/Popover/Popover.web.tsx
  • packages/blade/src/components/Popover/constants.ts
  • packages/blade/src/components/Popover/types.ts
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@saurabhdaware saurabhdaware marked this pull request as ready for review October 31, 2023 08:38
@saurabhdaware saurabhdaware added the Review - L1 First level of review label Oct 31, 2023
github-actions[bot]
github-actions bot reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 68b51bf and a5b3c65 commits.
Files selected (1)
  • .changeset/new-crabs-dream.md (1)
Files ignored due to filter (2)
  • packages/blade/src/components/Popover/tests/snapshots/Popover.native.test.tsx.snap
  • packages/blade/src/components/Popover/tests/snapshots/Popover.web.test.tsx.snap
Files not reviewed due to errors (1)
  • .changeset/new-crabs-dream.md (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@saurabhdaware saurabhdaware changed the title fix(Dropdown): change overlay token fix(Dropdown, Popover): use surface.popup.background token as background Oct 31, 2023
Base automatically changed from follow-smoke to master October 31, 2023 10:09
@saurabhdaware saurabhdaware merged commit 66a1626 into master Oct 31, 2023
10 checks passed
@saurabhdaware saurabhdaware deleted the feat/dropdownoverlay-token branch October 31, 2023 12:27
anuraghazra pushed a commit that referenced this pull request Apr 9, 2024
@saurabhdaware @rzpcibot
fix(Dropdown, Popover): use surface.popup.background token as backg…
6394194 
…round (#1753)

* fix: change overlay token

* fix: update web snapshots

* feat(tokens): add new tokens

* feat(tokens): add new tokens

* fix: remove old changes

* fix: remove npmrc

* feat: migrate overlay tokens (#1772)

* feat: migrate overlay token

* Create honest-glasses-sin.md

* empty commit

* test: update snapshots

* docs: changeset rephrasing

---------

Co-authored-by: rzpcibot <[email protected]>

* fix: payment theme conflict

* feat: use popup token in popover

* test: snapshots update

* Create new-crabs-dream.md

* fix: remove old changeset

---------

Co-authored-by: rzpcibot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chaitanyadeorukhkar chaitanyadeorukhkar chaitanyadeorukhkar approved these changes

@kamleshchandnani kamleshchandnani kamleshchandnani approved these changes

@anuraghazra anuraghazra Awaiting requested review from anuraghazra anuraghazra is a code owner

@dhruvdutt dhruvdutt Awaiting requested review from dhruvdutt

@nashcheez nashcheez Awaiting requested review from nashcheez

@divyanshu013 divyanshu013 Awaiting requested review from divyanshu013

@snitin315 snitin315 Awaiting requested review from snitin315 snitin315 is a code owner

Assignees

@kamleshchandnani kamleshchandnani

Labels
Review - L1 First level of review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saurabhdaware @kamleshchandnani @chaitanyadeorukhkar @rzpcibot