Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimize bundle size with isolated modules #1839
refactor: optimize bundle size with isolated modules #1839
Changes from all commits
e53ac42
3d00f19
734f218
4b68e60
ffedda3
79df5cb
ba0158b
9f21eec
ed77d7d
4261a5a
a117f41
7baf202
72a542a
55a3cb2
117c282
b48d07b
f8ef0cb
2d36f14
edfe95d
8c2afb9
02c1d9c
0a9c288
6da27a7
4bb6f00
7b75c7d
d5beca1
bafefd9
a071df9
8f369bf
a3a6a4f
d3e22cb
0ca8d47
5e11a0d
e2e4f73
537043f
8e0e164
b87b285
c67e99e
b573db9
11e61a5
cdf3e95
d94f9ed
50af723
c9b5a21
c83fff4
dae76a6
07deaa3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what did we change in this plugin from the original source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing, just kept it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arre then why did we moved it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because i cannot import
.ts
file in this.mjs
file without first transpiling it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@floating-ui/react
is no longer a peer dependency?