Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blade): add toast component #2000

Merged
merged 45 commits into from
Feb 15, 2024
Merged

feat(blade): add toast component #2000

merged 45 commits into from
Feb 15, 2024

Conversation

anuraghazra
Copy link
Member

Description

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: 0a90bd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 5, 2024

✅ PR title follows Conventional Commits specification.

@anuraghazra anuraghazra marked this pull request as ready for review February 8, 2024 13:26
@anuraghazra anuraghazra added the Review - L1 First level of review label Feb 12, 2024
Copy link

codesandbox-ci bot commented Feb 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a90bd6:

Sandbox Source
razorpay/blade: basic Configuration

saurabhdaware
saurabhdaware previously approved these changes Feb 12, 2024
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@chaitanyadeorukhkar
Copy link
Collaborator

chaitanyadeorukhkar commented Feb 14, 2024

@anuraghazra
The storybook UI breaks when you open the docs section and see a toast/promotional toast. Lets add some default height to the container here so that it doesn't break in the docs section
Screenshot 2024-02-14 at 3 38 46 PM

@chaitanyadeorukhkar
Copy link
Collaborator

@anuraghazra lets move the "Show toast" button in all stories to right corner? It gets hidden very easily

@chaitanyadeorukhkar
Copy link
Collaborator

@anuraghazra the container that has all the toasts seems to be too large from the top even when there aren't enough toasts to cover that whole area. This container has pointer-events: none which leads to any clickable behind that container to not be clickable anymore. For example, in this screenshot, the button behind the wrapper isn't clickable anymore.

Screenshot 2024-02-14 at 3 43 48 PM

@anuraghazra
Copy link
Member Author

This container has pointer-events: none which leads to any clickable behind that container to not be clickable anymore

🤔 the container has pointerevents:none thus it should not react to or block any pointer events, it seems to be working fine.

Screen.Recording.2024-02-14.at.3.51.44.PM.mov

@anuraghazra
Copy link
Member Author

It gets hidden very easily

Changed the height of docs to be 80vh, should not hide easily anymore.

saurabhdaware
saurabhdaware previously approved these changes Feb 14, 2024
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

packages/blade/src/components/Toast/useToast.tsx Outdated Show resolved Hide resolved
@chaitanyadeorukhkar chaitanyadeorukhkar merged commit 497799d into master Feb 15, 2024
14 checks passed
@chaitanyadeorukhkar chaitanyadeorukhkar deleted the anu/toast branch February 15, 2024 12:37
anuraghazra added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review - L2 Second level of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants