-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blade): add toast component #2000
Conversation
🦋 Changeset detectedLatest commit: 0a90bd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ PR title follows Conventional Commits specification. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a90bd6:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@anuraghazra |
@anuraghazra lets move the "Show toast" button in all stories to right corner? It gets hidden very easily |
@anuraghazra the container that has all the toasts seems to be too large from the top even when there aren't enough toasts to cover that whole area. This container has ![]() |
🤔 the container has pointerevents:none thus it should not react to or block any pointer events, it seems to be working fine. Screen.Recording.2024-02-14.at.3.51.44.PM.mov |
Changed the height of docs to be 80vh, should not hide easily anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
* test: add toast interaction tests * chore: update toast timing * chore: fix interaction tests
Description
Changes
Additional Information
Component Checklist